DOC Rework plot_ard.py example#22747
Conversation
jjerphan
left a comment
There was a problem hiding this comment.
Thank you for the revamp of this example, @ArturoAmorQ.
To me, it is much better than before.
Here are some suggestions. Also, I wanted to suggest some changes to improve the section on ARD but couldn't. You can find them in this commit: jjerphan@ede9eec.
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
|
Thanks for the comments, @jjerphan!
How do I fetch/implement your commit? |
|
@ArturoAmorQ: if you give me rights to create PRs to your repo, then I can create a PR for this specific commit. Alternatively if you add my fork as a remote and fetch its content, you should then be able to cherry-pick the commit. git remote add jjerphan git@github.com:jjerphan/scikit-learn.git
git fetch jjerphan
git cherry-pick ede9eec |
I did both, in case it's needed in the future. Thanks again! |
jjerphan
left a comment
There was a problem hiding this comment.
LGTM. Thank you, @ArturoAmorQ!
We should remove this example. We only need to create a redirection of this suppressed example to the new one at the following location in the doc https://github.com/scikit-learn/scikit-learn/blob/main/doc/conf.py#L249-L256 |
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
|
Thanks for your time and comments @jjerphan and @glemaitre :) |
|
Thanks @ArturoAmorQ LGTM |
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Reference Issues/PRs
Fixes #20740.
What does this implement/fix? Explain your changes.
The example on
ARDRegressionplot_ard.py stopped working since the release 0.23.This PR fixes it and reworks the example to:
make_regressionto create the synthetic datasetAny other comments?
This PR would make the example on
BayesianRidgeplot_bayesian_ridge.py redundant.One possibility is to suppress it in favor of this reworked example.