Skip to content

MAINT Revert HOTFIX introduced in #21549#21560

Merged
ogrisel merged 1 commit intoscikit-learn:mainfrom
jjerphan:revert_setuptools_2849_workaround
Nov 5, 2021
Merged

MAINT Revert HOTFIX introduced in #21549#21560
ogrisel merged 1 commit intoscikit-learn:mainfrom
jjerphan:revert_setuptools_2849_workaround

Conversation

@jjerphan
Copy link
Copy Markdown
Member

@jjerphan jjerphan commented Nov 5, 2021

Reference Issues/PRs

Reverts #21549.
Relates to pypa/setuptools#2855.

What does this implement/fix? Explain your changes.

The fix for pypa/setuptools#2849 has been introduced in setuptools 58.5.3 via pypa/setuptools#2855 (See: pypa/setuptools#2855 (comment)).

This reverts commit 953d101 which introduced a temporary hotfix.

…cikit-learn#21549)"

This reverts commit 953d101.

The fix for setuptools#21549 has been introduced in 58.5.3.

See: pypa/setuptools#2855 (comment)
@jjerphan jjerphan marked this pull request as ready for review November 5, 2021 08:00
@ogrisel ogrisel merged commit fac1ec8 into scikit-learn:main Nov 5, 2021
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Nov 29, 2021
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Dec 24, 2021
glemaitre pushed a commit that referenced this pull request Dec 25, 2021
…21549)" (#21560)

This reverts commit 953d101.

The fix for setuptools#21549 has been introduced in 58.5.3.

See: pypa/setuptools#2855 (comment)
@jjerphan jjerphan deleted the revert_setuptools_2849_workaround branch October 21, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants