FIX Don't use setuptools 58.5 which introduces regression#21549
FIX Don't use setuptools 58.5 which introduces regression#21549glemaitre merged 3 commits intoscikit-learn:mainfrom
Conversation
This is a temporary fix for: pypa/setuptools#2849
|
Unfortunately changing the dependency version in pyproject.toml alone does not work, probably because we do not use build isolation on the CI. I think we also need to change the setuptools setup in the configuration of the CI jobs. |
ogrisel
left a comment
There was a problem hiding this comment.
LGTM assuming this fixes the CI.
|
It seems to work on most builds. Let's wait for the fast tests to complete and merge without waiting for the slow PyPy job. |
adrinjalali
left a comment
There was a problem hiding this comment.
Somebody needs to remember to revert this PR once the issue is fixed on the setuptools side 😁
I propose to be responsible for reverting the commit when the issue is resolved. 🙂 |
|
I am merging now since the PyPy is in the testing part and the install was successful (while it would have broken before). Thanks, @jjerphan Let's track the |
…cikit-learn#21549)" This reverts commit 953d101. The fix for setuptools#21549 has been introduced in 58.5.3. See: pypa/setuptools#2855 (comment)
…21549)" (#21560) This reverts commit 953d101. The fix for setuptools#21549 has been introduced in 58.5.3. See: pypa/setuptools#2855 (comment)
…cikit-learn#21549)" (scikit-learn#21560) This reverts commit 953d101. The fix for setuptools#21549 has been introduced in 58.5.3. See: pypa/setuptools#2855 (comment)
…cikit-learn#21549)" (scikit-learn#21560) This reverts commit 953d101. The fix for setuptools#21549 has been introduced in 58.5.3. See: pypa/setuptools#2855 (comment)
…cikit-learn#21549)" (scikit-learn#21560) This reverts commit 953d101. The fix for setuptools#21549 has been introduced in 58.5.3. See: pypa/setuptools#2855 (comment)
…21549)" (#21560) This reverts commit 953d101. The fix for setuptools#21549 has been introduced in 58.5.3. See: pypa/setuptools#2855 (comment)
Reference Issues/PRs
pypa/setuptools#2849
What does this implement/fix? Explain your changes.
This is a temporary fix for: pypa/setuptools#2849