Made required changes to kernel_approximation.py#17473
Merged
thomasjpfan merged 6 commits intoscikit-learn:masterfrom Jun 6, 2020
Merged
Made required changes to kernel_approximation.py#17473thomasjpfan merged 6 commits intoscikit-learn:masterfrom
thomasjpfan merged 6 commits intoscikit-learn:masterfrom
Conversation
Member
|
looks like there's a small issue with the submitted changes @Mariam-ke (2k+ changes) Might be related to #17341 ? |
Contributor
Author
|
Yup I saw the untracked files and added them as well. |
Member
|
@Mariam-ke can you please remove them? they shouldn't be added. |
b99ad93 to
95c26bc
Compare
Contributor
Author
|
I just removed them. |
NicolasHug
reviewed
Jun 6, 2020
sklearn/kernel_approximation.py
Outdated
| Equals the dimensionality of the computed feature space. | ||
|
|
||
| random_state : int, RandomState instance or None, optional (default=None) | ||
| random_state : int, RandomState instance, default=None |
Member
There was a problem hiding this comment.
since None has a very specific meaning in the case of random_state, we should still mention it as a possible value. It does not correspond to "nothing" in this case:
Suggested change
| random_state : int, RandomState instance, default=None | |
| random_state : int, RandomState instance or None, default=None |
NicolasHug
reviewed
Jun 6, 2020
sklearn/kernel_approximation.py
Outdated
| Equals the dimensionality of the computed feature space. | ||
|
|
||
| random_state : int, RandomState instance or None, optional (default=None) | ||
| random_state : int, RandomState instance, default=None |
Member
There was a problem hiding this comment.
same thing here and in other places please @Mariam-ke ;)
thomasjpfan
reviewed
Jun 6, 2020
sklearn/kernel_approximation.py
Outdated
| Parameters | ||
| ---------- | ||
| sample_steps : int, optional | ||
| sample_steps : int |
Member
There was a problem hiding this comment.
Suggested change
| sample_steps : int | |
| sample_steps : int, default=2 |
sklearn/kernel_approximation.py
Outdated
| Returns | ||
| ------- | ||
| X_new : {array, sparse matrix}, \ | ||
| X_new : {ndarray, sparse matrix}, \ |
Member
There was a problem hiding this comment.
Suggested change
| X_new : {ndarray, sparse matrix}, \ | |
| X_new : {ndarray, sparse matrix}, \ |
sklearn/kernel_approximation.py
Outdated
| Attributes | ||
| ---------- | ||
| components_ : array, shape (n_components, n_features) | ||
| components_ : array-like of shape (n_components, n_features) |
Member
There was a problem hiding this comment.
These are explicitly numpy arrays.
Suggested change
| components_ : array-like of shape (n_components, n_features) | |
| components_ : ndarray of shape (n_components, n_features) |
sklearn/kernel_approximation.py
Outdated
| Subset of training points used to construct the feature map. | ||
|
|
||
| component_indices_ : array, shape (n_components) | ||
| component_indices_ : array-like of shape (n_components) |
Member
There was a problem hiding this comment.
Suggested change
| component_indices_ : array-like of shape (n_components) | |
| component_indices_ : ndarray of shape (n_components) |
sklearn/kernel_approximation.py
Outdated
| Indices of ``components_`` in the training set. | ||
|
|
||
| normalization_ : array, shape (n_components, n_components) | ||
| normalization_ : array-like of shape (n_components, n_components) |
Member
There was a problem hiding this comment.
Suggested change
| normalization_ : array-like of shape (n_components, n_components) | |
| normalization_ : ndarray of shape (n_components, n_components) |
sklearn/kernel_approximation.py
Outdated
| Returns | ||
| ------- | ||
| X_transformed : array, shape=(n_samples, n_components) | ||
| X_transformed : array-like of shape (n_samples, n_components) |
Member
There was a problem hiding this comment.
Suggested change
| X_transformed : array-like of shape (n_samples, n_components) | |
| X_transformed : ndarray of shape (n_samples, n_components) |
Contributor
Author
|
Made all the changes |
NicolasHug
reviewed
Jun 6, 2020
sklearn/kernel_approximation.py
Outdated
| Equals the dimensionality of the computed feature space. | ||
|
|
||
| random_state : int, RandomState instance or None, optional (default=None) | ||
| rrandom_state : int, RandomState instance, default=None |
Member
There was a problem hiding this comment.
Suggested change
| rrandom_state : int, RandomState instance, default=None | |
| random_state : int, RandomState instance or None, default=None |
Member
|
#DataUmbrella sprint |
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
References #16210
What does this implement/fix? Explain your changes.
Updated the required changes as per the suggested changes on the files changed tab
Any other comments?