[MRG] Deleted 'optional' specifier #16210
Closed
fraboeni wants to merge 1 commit intoscikit-learn:masterfrom
Closed
[MRG] Deleted 'optional' specifier #16210fraboeni wants to merge 1 commit intoscikit-learn:masterfrom
fraboeni wants to merge 1 commit intoscikit-learn:masterfrom
Conversation
NicolasHug
reviewed
Jan 25, 2020
Member
NicolasHug
left a comment
There was a problem hiding this comment.
thanks for the PR, a few comments
| Returns | ||
| ------- | ||
| X_new : {array, sparse matrix}, \ | ||
| X_new : {array-like, sparse matrix}, \ |
Member
There was a problem hiding this comment.
Suggested change
| X_new : {array-like, sparse matrix}, \ | |
| X_new : {ndarray, sparse matrix}, \ |
| Degree of the polynomial kernel. Ignored by other kernels. | ||
|
|
||
| kernel_params : mapping of string to any, optional | ||
| kernel_params : mapping of string to any |
Member
There was a problem hiding this comment.
Suggested change
| kernel_params : mapping of string to any | |
| kernel_params : dict, default=None |
| Attributes | ||
| ---------- | ||
| components_ : array, shape (n_components, n_features) | ||
| components_ : array-like of shape (n_components, n_features) |
Member
There was a problem hiding this comment.
should be ndarray here and below
| Returns | ||
| ------- | ||
| X_transformed : array, shape=(n_samples, n_components) | ||
| X_transformed : array-like of shape (n_samples, n_components) |
| sample_steps : int | ||
| Gives the number of (complex) sampling points. | ||
| sample_interval : float, optional | ||
| sample_interval : float |
Member
There was a problem hiding this comment.
Suggested change
| sample_interval : float | |
| sample_interval : float, default=None |
glemaitre
requested changes
Jan 26, 2020
| Equals the dimensionality of the computed feature space. | ||
|
|
||
| random_state : int, RandomState instance or None, optional (default=None) | ||
| random_state : int, RandomState instance or None, default=None |
Member
There was a problem hiding this comment.
Suggested change
| random_state : int, RandomState instance or None, default=None | |
| random_state : int, RandomState instance, default=None |
| Equals the dimensionality of the computed feature space. | ||
|
|
||
| random_state : int, RandomState instance or None, optional (default=None) | ||
| random_state : int, RandomState instance or None, default=None |
Member
There was a problem hiding this comment.
Suggested change
| random_state : int, RandomState instance or None, default=None | |
| random_state : int, RandomState instance, default=None |
| sample_steps : int | ||
| Gives the number of (complex) sampling points. | ||
| sample_interval : float, optional | ||
| sample_interval : float |
Member
There was a problem hiding this comment.
Suggested change
| sample_interval : float | |
| sample_interval : float, default=None |
| Parameters | ||
| ---------- | ||
| sample_steps : int, optional | ||
| sample_steps : int |
Member
There was a problem hiding this comment.
Suggested change
| sample_steps : int | |
| sample_steps : int, default=2 |
| How many data points will be used to construct the mapping. | ||
|
|
||
| random_state : int, RandomState instance or None, optional (default=None) | ||
| random_state : int, RandomState instance or None, default=None |
Member
There was a problem hiding this comment.
Suggested change
| random_state : int, RandomState instance or None, default=None | |
| random_state : int, RandomState instance, default=None |
Contributor
|
@fraboeni can you continue to work on this? |
Contributor
Author
Unfortunately, I am so busy at work at the moment, that I don't find the time. |
Contributor
|
@fraboeni thanks for letting us know. |
Contributor
|
Take |
Contributor
|
Closed by #17473. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with @lopusz and @magda-zielinska
Reference Issues/PRs
#15761
What does this implement/fix? Explain your changes.
Deletes optional specifier and changes array to array-like