Skip to content

[MRG+1] MNT fix E731#16786

Merged
rth merged 2 commits intoscikit-learn:masterfrom
lorentzenchr:e731
Mar 30, 2020
Merged

[MRG+1] MNT fix E731#16786
rth merged 2 commits intoscikit-learn:masterfrom
lorentzenchr:e731

Conversation

@lorentzenchr
Copy link
Copy Markdown
Member

@lorentzenchr lorentzenchr commented Mar 28, 2020

What does this implement/fix? Explain your changes.

This PR fixes some E731 linter warnings.

@lorentzenchr
Copy link
Copy Markdown
Member Author

lorentzenchr commented Mar 28, 2020

I hope the test failure is unrelated to this PR.

rth
rth approved these changes Mar 28, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a side note, I never really understood/agreed with the issue about assigning labmba functions style wise, and one line functions is not much better IMO (while multiline functions would be somewhat verbose).

Sill LGTM, given that we address linter errors.

The failing check seems to fail because runtime is different, possibly after #16777

Could you re-trigger CI to see it's reproducible (git commit --allow-empty)? In any case we would likely need to fix that check in some other PR.

@lorentzenchr
Copy link
Copy Markdown
Member Author

lorentzenchr commented Mar 28, 2020

As a side note, I never really understood/agreed with the issue about assigning labmba functions style wise, and one line functions is not much better IMO (while multiline functions would be somewhat verbose).

At least, my editor will show no more linter errors:smirk:

@lorentzenchr lorentzenchr changed the title [MRG] MNT fix E731 [MRG+1] MNT fix E731 Mar 30, 2020
@rth
Copy link
Copy Markdown
Member

rth commented Mar 30, 2020

Merging thanks! Just FYI, we generally try to avoid cosmetic changes as it has the potential to create conflicts in PRs #11336 .

@rth rth merged commit a2ccc33 into scikit-learn:master Mar 30, 2020
@lorentzenchr lorentzenchr deleted the e731 branch March 31, 2020 17:47
gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020
@gio8tisu
STY PEP8 fix E731 in linear_model/_logistic.py (scikit-learn#16786)
c10a1b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rth rth rth approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

module:linear_model module:utils

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lorentzenchr @rth