[MRG] MNT remove coupling between pipeline methods#16777
Merged
TomDLT merged 1 commit intoscikit-learn:masterfrom Mar 27, 2020
Merged
[MRG] MNT remove coupling between pipeline methods#16777TomDLT merged 1 commit intoscikit-learn:masterfrom
TomDLT merged 1 commit intoscikit-learn:masterfrom
Conversation
Member
Author
|
maybe @rth and @thomasjpfan ? |
rth
approved these changes
Mar 27, 2020
Member
rth
left a comment
There was a problem hiding this comment.
Overall sounds good, but I'm not that familiar with the pipeline code so a second thorough review would be good.
TomDLT
reviewed
Mar 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a
_check_fit_paramsmethod to consistently validate fit params.Previously we were relying on
_fitto return the fit_params of the last step (when it exists).