DOC promote shallow copy in the docs#16423
Conversation
|
IMHO this isn't relevant for most contributors and it will add noise to our docs which are already overloaded with info |
|
This (and the default mkl inclusion by conda) were the main issue when I was in Nairobi. Not everybody has access to a fast internet connection, and not including this disproportionately puts those people in a disadvantage. Even I've had this issue at home, the internet speed and the github servers around the world are not all the same. |
|
Maybe just remove it from the contributing guide? Its goal is to be as concise as possible and we recently trimmed it down, leaving special cases for other sections |
|
What are the chances of somebody who's reading the contributing guide needing it, compared to somebody who's reading the advanced installation? Doesn't make sense to me to remove it from the contributing guide. If anything, we can remove it from the advanced installation if you want. But I really don't get why you'd argue for not having it. |
ogrisel
left a comment
There was a problem hiding this comment.
I think I liked the earlier version a bit better because it makes it possible to copy and paste the full line in one go.
But I'm fine with both.
* DOC promote shallow copy in the docs * a shorter version
* DOC promote shallow copy in the docs * a shorter version
Fixes #16008
Seems like we rather promote a shallow copy instead of touching our git history. This PR puts that in the contributing guides.