Deprecate public attributes in linear_models SGD classes#16261
Deprecate public attributes in linear_models SGD classes#16261glemaitre merged 20 commits intoscikit-learn:masterfrom chbrandt:issue_14364
linear_models SGD classes#16261Conversation
|
Thanks @chbrandt ! Could you please fix the lint errors? |
jeremiedbb
left a comment
There was a problem hiding this comment.
Thanks @chbrandt. Here are a few comments. Please also add a what's new entry in v0.23.rst.
|
Thanks. Please rename this PR with a more explicit title. There is no need to mention the issue ID in the title since most people seeing it in the list will not know what it is. |
linear_models SGD classes
jeremiedbb
left a comment
There was a problem hiding this comment.
I just still have one remark about new attribute names.
rth
left a comment
There was a problem hiding this comment.
(Just changing status to "changes requested", to indicate that no new reviews are needed at this point)
jeremiedbb
left a comment
There was a problem hiding this comment.
Here's a new batch of comments
jeremiedbb
left a comment
There was a problem hiding this comment.
looks good @chbrandt. Just a few remaining comments
There was a problem hiding this comment.
I pushed some nitpicks.
lgtm, thanks @chbrandt !
ping @glemaitre for another review
glemaitre
left a comment
There was a problem hiding this comment.
LGTM. Waiting for CIs to turn green before merging.
|
I am merging. The issue with the CI is due to we did not merge master into the branch. This should be safe. Thanks @chbrandt :) |
|
Cool! Thanks guys :) |
Reference Issues/PRs
Partially addresses #14364
What does this implement/fix? Explain your changes.
Attributes were made "private", properties with the deprecated names were added as indicated in the docs