-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
Make attributes private for SGDClassifier and SGDRegressor #14364
Copy link
Copy link
Closed
Labels
good first issueEasy with clear instructions to resolveEasy with clear instructions to resolvehelp wanted
Description
I think it would make sense to make the following attributes private as opposed to public:
- average_coef_
- average_intercept_
- standard_coef_
- standard_intercept_
The reason for making these attributes private is because:
- average_coef_ and standard_coef_ are there to help determine the value of coef_
- average_intercept_ and standard_intercept_ are there to help determine the value of intercept_
- therefore, none of these intermediary attributes should be exposed to users as public attributes
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
good first issueEasy with clear instructions to resolveEasy with clear instructions to resolvehelp wanted