Confusion matrix derived metrics#15522
Closed
ghost wants to merge 11 commits intoscikit-learn:mainfrom
Closed
Conversation
added 11 commits
November 2, 2019 15:07
Co-authored-by: samskruthi padigepati <https://github.com/ddhar1> Co-authored-by: Divya Dhar<https://github.com/samskruthireddy>
Co-authored-by: samskruthi padigepati <https://github.com/ddhar1> Co-authored-by: Divya Dhar<https://github.com/samskruthireddy>
Co-authored-by: Divya Dhar <https://github.com/ddhar1> Co-authored-by: samskruthi padigepati <https://github.com/samskruthireddy>
Co-authored-by: samskruthi padigepati <https://github.com/samskruthireddy>
Member
|
This requires adding to test_common.py and specific behaviours tested in test_classification.py |
glemaitre
reviewed
Nov 7, 2019
Member
glemaitre
left a comment
There was a problem hiding this comment.
I am unsure about the naming. I think that we need to use the full name (e.g. true_positive_rate) instead of acronym (e.g. tpr).
| Ground truth (correct) labels for n_samples samples. | ||
|
|
||
| y_pred : array-like of float, shape = (n_samples, n_classes) or (n_samples,) | ||
| y_pred : array-like of float, shape = (n_samples, n_classes) |
Member
There was a problem hiding this comment.
Suggested change
| y_pred : array-like of float, shape = (n_samples, n_classes) | |
| y_pred : array-like of float, shape = (n_samples, n_classes) \ |
|
|
||
| y_pred : array-like of float, shape = (n_samples, n_classes) or (n_samples,) | ||
| y_pred : array-like of float, shape = (n_samples, n_classes) | ||
| or (n_samples,) |
Member
There was a problem hiding this comment.
Suggested change
| or (n_samples,) | |
| or (n_samples,) |
Contributor
haochunchang
left a comment
There was a problem hiding this comment.
Good work! @samskruthiReddy
Is this PR work in progress?
I would like to work on this if this PR is stalled.
| tpr : float (if average is not None) or array of float, shape =\ | ||
| [n_unique_labels] | ||
|
|
||
| fpr : float (if average is not None) or array of float, , shape =\ |
Contributor
There was a problem hiding this comment.
Just a small extra comma :)
Suggested change
| fpr : float (if average is not None) or array of float, , shape =\ | |
| fpr : float (if average is not None) or array of float, shape =\ |
| Examples | ||
| -------- | ||
| >>> import numpy as np | ||
| >>> from sklearn.metrics import precision_recall_fscore_support |
Contributor
There was a problem hiding this comment.
Is this a dependency of this function?
Since the following examples did not use this function.
Suggested change
| >>> from sklearn.metrics import precision_recall_fscore_support |
Comment on lines
+1716
to
+1726
| if average == 'weighted': | ||
| weights = pos_sum | ||
| if weights.sum() == 0: | ||
| zero_division_value = 0.0 if zero_division in ["warn", 0] else 1.0 | ||
| # precision is zero_division if there are no positive predictions | ||
| # recall is zero_division if there are no positive labels | ||
| # fscore is zero_division if all labels AND predictions are | ||
| # negative | ||
| return (zero_division_value if pred_sum.sum() == 0 else 0, | ||
| zero_division_value, | ||
| zero_division_value if pred_sum.sum() == 0 else 0) |
Contributor
There was a problem hiding this comment.
Here seems to only return 3 values.
Comment on lines
+1600
to
+1601
| alters 'macro' to account for label imbalance; it can result in an | ||
| F-score that is not between precision and recall. |
Contributor
There was a problem hiding this comment.
I guess this function does not return F-score.
Suggested change
| alters 'macro' to account for label imbalance; it can result in an | |
| F-score that is not between precision and recall. | |
| alters 'macro' to account for label imbalance. |
Comment on lines
+1556
to
+1558
| If ``pos_label is None`` and in binary classification, this function | ||
| returns the average precision, recall and F-measure if ``average`` | ||
| is one of ``'micro'``, ``'macro'``, ``'weighted'`` or ``'samples'``. |
Contributor
There was a problem hiding this comment.
Suggested change
| If ``pos_label is None`` and in binary classification, this function | |
| returns the average precision, recall and F-measure if ``average`` | |
| is one of ``'micro'``, ``'macro'``, ``'weighted'`` or ``'samples'``. | |
| If ``pos_label is None`` and in binary classification, this function | |
| returns the true positive rate, false positive rate, true negative rate | |
| and false negative rate if ``average`` is one of ``'micro'``, ``'macro'``, | |
| ``'weighted'`` or ``'samples'``. |
Member
|
@haochunchang it's been marked as 'stalled' so I think you can take over |
haochunchang
added a commit
to haochunchang/scikit-learn
that referenced
this pull request
May 18, 2020
Modify documentation and add deprecation of position arg.
haochunchang
added a commit
to haochunchang/scikit-learn
that referenced
this pull request
May 18, 2020
Modify doc and add deprecation to position arg.
haochunchang
added a commit
to haochunchang/scikit-learn
that referenced
this pull request
May 18, 2020
Modify doc and add deprecation to position arg.
Contributor
|
I have opened a new PR #17265 to take over this stalled PR. |
Contributor
|
@cmarmo, maybe the label "help wanted" should be removed from this PR. Thanks. |
3 tasks
Member
|
closing in favor of #19556 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Adding Fall-out, Miss rate, specificity as metrics #5516
What does this implement/fix? Explain your changes.
Implemented a function which returns fpr, tpr, fnr, tnr.
Any other comments?
Implementation of seperate functions for each metric which calls this function is still pending.
Co-authored by @ddhar1 @samskruthiReddy