Skip to content

FEA Confusion matrix derived metrics#19556

Open
Pawel-Kranzberg wants to merge 201 commits intoscikit-learn:mainfrom
Pawel-Kranzberg:confusion-matrix-derived-metrics
Open

FEA Confusion matrix derived metrics#19556
Pawel-Kranzberg wants to merge 201 commits intoscikit-learn:mainfrom
Pawel-Kranzberg:confusion-matrix-derived-metrics

Conversation

@Pawel-Kranzberg
Copy link
Copy Markdown

@Pawel-Kranzberg Pawel-Kranzberg commented Feb 25, 2021

Reference Issues/PRs

Continues #17265
Fixes #5516

What does this implement/fix? Explain your changes.

Add metrics.specificity_score and metrics.npv_score, based on metrics.fpr_tpr_fnr_tnr_scores from #17265

Any other comments?

samskruthi reddy padigepati and others added 21 commits May 18, 2020 21:59
Co-authored-by: samskruthi padigepati <https://github.com/ddhar1>
Co-authored-by: Divya Dhar<https://github.com/samskruthireddy>
Co-authored-by: samskruthi padigepati <https://github.com/ddhar1>
Co-authored-by: Divya Dhar<https://github.com/samskruthireddy>
Co-authored-by: Divya Dhar  <https://github.com/ddhar1>
Co-authored-by: samskruthi padigepati <https://github.com/samskruthireddy>
Co-authored-by: samskruthi padigepati <https://github.com/samskruthireddy>
Modify doc and add deprecation to position arg.
Add test for binary classification.
(Modify some lines to pass flake8)
Copy link
Copy Markdown
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

specificity_score also needs adding to test_common

@Pawel-Kranzberg
Copy link
Copy Markdown
Author

image

@adrinjalali
Copy link
Copy Markdown
Member

@lorentzenchr would you be able to maybe have a look?

@lorentzenchr
Copy link
Copy Markdown
Member

From the long discussion in #5516, better ping @jnothman @amueller @glemaitre .

@lorentzenchr
Copy link
Copy Markdown
Member

@Pawel-Kranzberg Could you please stop merging the main branch as long as there are no merge conflict? The reason is that it might hide discussions in Github and also generates notifications. And it should be in your interest that maintainers don't unsubscribe from this PR.

@JoshuaDBruton
Copy link
Copy Markdown

JoshuaDBruton commented Feb 26, 2025

Hi everyone, I have need for specificity_score as well and it would be convenient if it worked like Recall and the others that are available. I have added it locally and was considering opening a PR but saw this one was open already.

Just seconding that this would be a useful thing.

I don't know if there are still plans to merge this PR? Should I open a second PR covering just specificity_score or is this still active?

@Pawel-Kranzberg
Copy link
Copy Markdown
Author

Hi everyone, I have need for specificity_score as well and it would be convenient if it worked like Recall and the others that are available. I have added it locally and was considering opening a PR but saw this one was open already.

Just seconding that this would be a useful thing.

I don't know if there are still plans to merge this PR? Should I open a second PR covering just specificity_score or is this still active?

From my perspective it is still active.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding Fall-out, Miss rate, specificity as metrics

10 participants