MNT towards removing assert_equal, etc#14222
Merged
NicolasHug merged 22 commits intoscikit-learn:masterfrom Jul 1, 2019
Merged
MNT towards removing assert_equal, etc#14222NicolasHug merged 22 commits intoscikit-learn:masterfrom
NicolasHug merged 22 commits intoscikit-learn:masterfrom
Conversation
jnothman
approved these changes
Jun 30, 2019
Member
jnothman
left a comment
There was a problem hiding this comment.
These are all automatic, yeah?
Member
Author
|
assert_equal(condition, "starting "
"a very long message")It generates invalid code, and those are the ones I manually fixed, and then there were a bunch of pep8 issues that I fixed separately mostly in 0e5d4e7 Then there was removal of the unused imports, which |
glemaitre
approved these changes
Jul 1, 2019
NicolasHug
approved these changes
Jul 1, 2019
26 tasks
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #14215
This moves the codebase towards removing the assert_equal, etc.
Some instances are still left, since the nose2pytest did not fix them.