Skip to content

Remove assert_equal and co. from the tests #14215

@NicolasHug

Description

@NicolasHug

(Saving this for the upcoming sprints, ideally)

Let's remove the use of assert_equal, assert_greater, and assert_greater_equal in our tests.

These should be changed to simply assert a == b, assert a > b or assert a >= b.

For contributors: pick one of the modules below, and please comment on this issue saying e.g. "I'm working on cluster/tests", to avoid other contributors choosing the same modules.

You can see all the occurrences of the entries that need to be removed with e.g. git grep "assert_equal" sklearn/ensemble/tests/.

Modules that need cleaning

  • sklearn/cluster/tests/
  • sklearn/compose/tests/
  • sklearn/covariance/tests/
  • sklearn/cross_decomposition/tests/
  • sklearn/datasets/tests/
  • sklearn/decomposition/tests/
  • sklearn/ensemble/tests/
  • sklearn/feature_extraction/tests/
  • sklearn/feature_selection/tests/
  • sklearn/gaussian_process/tests/
  • sklearn/linear_model/tests/
  • sklearn/manifold/tests/
  • sklearn/metrics/cluster/tests/
  • sklearn/metrics/tests/
  • sklearn/mixture/tests/
  • sklearn/model_selection/tests/
  • sklearn/neighbors/tests/
  • sklearn/neural_network/tests/
  • sklearn/preprocessing/tests/
  • sklearn/random_projection.py
  • sklearn/semi_supervised/tests/
  • sklearn/svm/tests/
  • sklearn/tests/
  • sklearn/tree/tests/
  • sklearn/utils/estimator_checks.py
  • sklearn/utils/tests/

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions