Fix more formatting inconsistencies#13787
Merged
qinhanmin2014 merged 3 commits intoscikit-learn:masterfrom May 5, 2019
Merged
Conversation
Contributor
Author
|
It's showing commits from #13747 for some reason... |
Member
|
You needed to start your new branch at master, e.g. We have not historically fixed pep8 issues to avoid conflicts in other pull requests. I don't know if that's a big risk now that many files are fairly stable. I'm very happy to see the docstring improvements. |
158cc9c to
6367997
Compare
NicolasHug
approved these changes
May 5, 2019
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
May 6, 2019
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure how people feel about these kinds of changes, but I've just been writing a script to find inconsistencies in the code formatting.
All changes here are not super important, but because I am fixing things that only occur in a few places, it's obvious it is wrong.
Examples
Incorrect header delimiter
to
Incorrect number of header delimiters
to
Insufficient spaces before inline comment
See https://www.python.org/dev/peps/pep-0008/#inline-comments
to