Skip to content

Fix spacing and formatting inconsistencies#13747

Merged
jnothman merged 4 commits intoscikit-learn:masterfrom
Scowley4:master
May 1, 2019
Merged

Fix spacing and formatting inconsistencies#13747
jnothman merged 4 commits intoscikit-learn:masterfrom
Scowley4:master

Conversation

@Scowley4
Copy link
Copy Markdown
Contributor

@Scowley4 Scowley4 commented Apr 29, 2019 •
edited
Loading

Fixes spacing/formatting inconsistencies in code. Examples of changes shown below.

Examples

Endline comments

from scipy.cluster import hierarchy     # imports PIL

to

from scipy.cluster import hierarchy  # imports PIL

Extra spaces in text

feature matrix  representing n_samples samples to be clustered

to

feature matrix representing n_samples samples to be clustered

Line up arguments

kmeans = MiniBatchKMeans(n_clusters=2,
        random_state=0,

to

kmeans = MiniBatchKMeans(n_clusters=2,
                         random_state=0,

Add 0s for readability

true_cov = np.array([[.8, 0., .2, 0.]
                     [0., .4, 0., 0.],

to

true_cov = np.array([[0.8, 0.0, 0.2, 0.0],
                     [0.0, 0.4, 0.0, 0.0],

XavierSATTLER
XavierSATTLER approved these changes May 1, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@XavierSATTLER XavierSATTLER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are small changes, but it definitely looks better.

jnothman
jnothman approved these changes May 1, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Scowley4

@jnothman jnothman merged commit e7ca623 into scikit-learn:master May 1, 2019
@Scowley4 Scowley4 mentioned this pull request May 4, 2019
Merged
jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request May 6, 2019
@Scowley4 @jnothman
Fix spacing and formatting inconsistencies (scikit-learn#13747)
51d25d7
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
@Scowley4 @koenvandevelde
Fix spacing and formatting inconsistencies (scikit-learn#13747)
9e402f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnothman jnothman jnothman approved these changes

+1 more reviewer

@XavierSATTLER XavierSATTLER XavierSATTLER approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Scowley4 @jnothman @XavierSATTLER