Skip to content

Additions to 0.20 between RC and release#11948

Merged
amueller merged 0 commit intoscikit-learn:0.20.Xfrom
jnothman:0.20postrc
Sep 25, 2018
Merged

Additions to 0.20 between RC and release#11948
amueller merged 0 commit intoscikit-learn:0.20.Xfrom
jnothman:0.20postrc

Conversation

@jnothman
Copy link
Copy Markdown
Member

@jnothman jnothman commented Aug 30, 2018

This PR and branch are for tracking which commits from master are to be cherry-picked into 0.20 final, but missed rc1.

@ogrisel
Copy link
Copy Markdown
Member

ogrisel commented Sep 17, 2018

I don't understand why appveyor says " AppVeyor was unable to build non-mergeable pull request" while Github says "This branch has no conflicts with the base branch. Merging can be performed automatically." at the same time.

@jnothman
Copy link
Copy Markdown
Member Author

jnothman commented Sep 17, 2018 via email

@amueller
Copy link
Copy Markdown
Member

do you want to try and update it? Should I? I don't think there's anything in the way of releasing right now.

@amueller
Copy link
Copy Markdown
Member

Does it make sense to cherry-pick #11945 ?

These should probably be picked:
#12133 minor fix in GradientBoostingRegressor docs
#11963 typos and fixes to whatsnew for 0.20
#12124 DOC covariance doctest examples
#11922 DOC Removed duplicated doc in tree.rst
#12114 Fix FutureWarnings in logistic regression examples

There's no reason not to pick
#12089 Update test_metaestimators to pass y parameter when calling score

Rest looks good. Might just do that now and start building the wheels...

@amueller amueller mentioned this pull request Sep 24, 2018
amueller added a commit that referenced this pull request Sep 24, 2018
@amueller amueller merged commit 1dc0205 into scikit-learn:0.20.X Sep 25, 2018
@jnothman
Copy link
Copy Markdown
Member Author

Closing as superseded by #12151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants