[MRG+1] Add verbose option to Pipeline, FeatureUnion, and ColumnTransformer by thomasjpfan · Pull Request #11364 · scikit-learn/scikit-learn

thomasjpfan · 2018-06-27T03:50:36Z

Reference Issues/PRs

Continues work on PR #10435.

Fixes #9668. Fixes #8568. Fixes #5298. Fixes #5321.

What does this implement/fix? Explain your changes.

Adapts the new functions in pipeline.py to work with ColumnTransformer.

- Each line printed by Pipeline and FeatureUnion, when their verbosity mode is on, will be 70 characters long.

Fix error message bug

# Conflicts: # sklearn/pipeline.py # sklearn/utils/__init__.py # sklearn/utils/tests/test_utils.py

jnothman · 2018-06-27T08:07:05Z

Thanks for fixing that up. This is nice.
Of course, it wouldn't hurt to provide verbose in ColumnTransformer if we do so in FeatureUnion.

thomasjpfan · 2018-06-27T19:23:03Z

I updated this PR with verbose support in ColumnTransformer.

thomasjpfan · 2019-04-10T02:28:49Z

Merge conflicts fixed... for now.

NicolasHug · 2019-04-10T11:31:13Z

I'll review today

NicolasHug

Some first comments

Additionally, make_column_transformer is missing support for verbose attribute

doc/whats_new/v0.20.rst

sklearn/compose/_column_transformer.py

sklearn/pipeline.py

sklearn/utils/__init__.py

NicolasHug · 2019-04-10T11:42:57Z

sklearn/pipeline.py

-                        .format(list(kwargs.keys())[0]))
-    return FeatureUnion(_name_estimators(transformers), n_jobs=n_jobs)
+        raise TypeError('Unknown keyword arguments: "{}"'.format(
+            list(kwargs.keys())[0]))


hasn't been addressed

sklearn/tests/test_pipeline.py

sklearn/pipeline.py

sklearn/utils/__init__.py

NicolasHug · 2019-04-14T15:51:55Z

sklearn/pipeline.py

+
    # Estimator interface

    def _fit(self, X, y=None, **fit_params):


Not strictly related to this PR, but I find it confusing that this is called _fit while it actually does some transforming jobs as well.

Mind as well call it _fit_transform or if we want to be more specific: _fit_transform_without_final :)

_fit_transform_without_final sounds great to me

sklearn/pipeline.py

thomasjpfan · 2019-04-18T00:39:26Z

This PR has been updated to use the phrase "Processing _____" when returning the verbose output.

NicolasHug

Nitpicks but LGTM

NicolasHug · 2019-04-18T18:41:09Z

sklearn/pipeline.py

+                Xt = last_step.fit_transform(Xt, y, **fit_params)
+            else:
+                Xt = last_step.fit(Xt, y, **fit_params).transform(Xt)
+        return Xt


Maybe we should use

if... : return Xt elif...: return ... else: return ...

NicolasHug · 2019-04-18T18:41:21Z

sklearn/pipeline.py

+    """
+    Fits ``transformer`` to ``X`` and ``y``. The transformed result is returned
+    with the fitted transformer. If ``weight`` is not ``None``, the result will
+    be multipled by ``weight``.


Suggested change

be multipled by ``weight``.

be multiplied by ``weight``.

NicolasHug

Nitpicks but LGTM

jnothman · 2019-04-21T14:51:05Z

Let's ship it! Thanks for wrapping it up, @thomasjpfan

…er (scikit-learn#11364)

…ransformer (scikit-learn#11364)" This reverts commit bed12f6.

…er (scikit-learn#11364)

…t-learn#11364

Karan Desai and others added 24 commits September 1, 2017 12:27

ENH Add verbose option and corresponding tests for Pipeline.

ce53c81

ENH Add verbose option and corresponding tests for FeatureUnion.

c7bbb94

ENH Add _pretty_print method to print from Pipeline properly.

d1353fb

- Each line printed by Pipeline and FeatureUnion, when their verbosity mode is on, will be 70 characters long.

Add a changelog entry about verbosity of Pipeline.

a981bdc

Fix bug in pipeline transformer list in-place assignment;

3bddca1

Fix error message bug

Extend make_pipeline to support the verbose kwarg as well

ba083b8

Fix whats new to reflect the Pipeline verbose change

5857d5e

Remove _BasePipeline resulting from a bad rebase

72f4d0e

Revert FeatureUnion.transformer_list to list instead of sequence

1b7245e

Extend FeatureUnion to support the verbose kwarg as well

3938adc

Minor tidy-up

efb4aac

Add message_with_time helper

2e5b6cc

Merge branch 'master' into verbose-pipeline

f60eb7b

Rewrite verbose pipeline logic

45f346b

Test logging utils

3950fb0

Param docstring

6807457

pytest<3.3 does return namedtuples

badf235

Don't forcefully adjust timing on Windows as joblib does

7de5ed8

Need some __future__

5dce7c1

Rm unused import

b8c56d8

Merge branch 'master' into verbose-pipeline

57edbfa

Merge branch 'master' into verbose-pipeline

2caef80

Merge remote-tracking branch 'upstream/master' into verbose-pipeline

b92da44

# Conflicts: # sklearn/pipeline.py # sklearn/utils/__init__.py # sklearn/utils/tests/test_utils.py

ENH: Adapts ColumnTransformer to pipeline funcs

6997c8f

thomasjpfan mentioned this pull request Jun 27, 2018

[MRG] Add verbose option to Pipeline and FeatureUnion #10435

Closed

thomasjpfan added 2 commits June 27, 2018 10:37

ENH: Adds verbose to ColumnTransformer

fb8c123

DOC: Fix doctest

b3d5c8e

thomasjpfan changed the title ~~MRG: Add verbose option to Pipeline and FeatureUnion while fixing ColumnTransformer~~ MRG: Add verbose option to Pipeline, FeatureUnion, and ColumnTransformer Jun 27, 2018

NicolasHug reviewed Apr 10, 2019

View reviewed changes

thomasjpfan added 2 commits April 12, 2019 11:27

CLN Address comments

3a42ba5

DOC Clears up verbose doc

0c6ed63

NicolasHug reviewed Apr 14, 2019

View reviewed changes

thomasjpfan added 2 commits April 14, 2019 14:11

ENH Proper handling of None and passthrough

37e1f64

STY

94ed049

NicolasHug reviewed Apr 15, 2019

View reviewed changes

sklearn/pipeline.py Show resolved Hide resolved

thomasjpfan added 2 commits April 15, 2019 14:06

Merge remote-tracking branch 'upstream/master' into verbose-pipeline

4759cb4

CLN Uses the word processing

94e3bd5

NicolasHug approved these changes Apr 18, 2019

View reviewed changes

CLN Address comments

7675454

jnothman merged commit 8edd9f9 into scikit-learn:master Apr 21, 2019

jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Apr 25, 2019

ENH Add verbose option to Pipeline, FeatureUnion, and ColumnTransform…

2a2caff

…er (scikit-learn#11364)

xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019

ENH Add verbose option to Pipeline, FeatureUnion, and ColumnTransform…

bed12f6

…er (scikit-learn#11364)

xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019

Revert "ENH Add verbose option to Pipeline, FeatureUnion, and ColumnT…

d2e33b9

…ransformer (scikit-learn#11364)" This reverts commit bed12f6.

xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019

Revert "ENH Add verbose option to Pipeline, FeatureUnion, and ColumnT…

4f9293c

…ransformer (scikit-learn#11364)" This reverts commit bed12f6.

koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019

ENH Add verbose option to Pipeline, FeatureUnion, and ColumnTransform…

4dda655

…er (scikit-learn#11364)

amueller mentioned this pull request Aug 7, 2019

Verbose VotingClassifier #10360

Closed

hannahbrucemacdonald added a commit to hannahbrucemacdonald/scikit-learn that referenced this pull request Aug 24, 2019

adding _log_message function, changing verbose to bool to match sciki…

ad47522

…t-learn#11364

hannahbrucemacdonald mentioned this pull request Aug 24, 2019

[MRG] Verbose flag for VotingClassifier and VotingRegressor #14772

Closed

reshamas mentioned this pull request Dec 30, 2019

API add verbose flag for Voting* estimators #15991

Closed

cmarmo mentioned this pull request Jan 9, 2020

ENH Add verbose option to VotingClassifier and VotingRegre… #16069

Merged

cmarmo mentioned this pull request Feb 6, 2020

Verbose Option for Classifier and Regressor Chains #16380

Closed

efiegel mentioned this pull request Dec 1, 2020

API add verbose argument in ClassifierChain and RegressorChain #18947

Closed

MezentsevIlya mentioned this pull request Jan 28, 2021

Elapsed time for transforming in Pipeline and FeatureUnion #19291

Open


		# Estimator interface

		def _fit(self, X, y=None, **fit_params):

Uh oh!

Conversation

thomasjpfan commented Jun 27, 2018

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Uh oh!

jnothman commented Jun 27, 2018

Uh oh!

thomasjpfan commented Jun 27, 2018

Uh oh!

thomasjpfan commented Apr 10, 2019

Uh oh!

NicolasHug commented Apr 10, 2019

Uh oh!

NicolasHug left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NicolasHug Apr 10, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NicolasHug Apr 14, 2019

Choose a reason for hiding this comment

Uh oh!

thomasjpfan Apr 14, 2019

Choose a reason for hiding this comment

Uh oh!

NicolasHug Apr 15, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

thomasjpfan commented Apr 18, 2019

Uh oh!

NicolasHug left a comment

Choose a reason for hiding this comment

Uh oh!

NicolasHug Apr 18, 2019

Choose a reason for hiding this comment

Uh oh!

NicolasHug Apr 18, 2019

Choose a reason for hiding this comment

Uh oh!

NicolasHug left a comment

Choose a reason for hiding this comment

Uh oh!

jnothman commented Apr 21, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

NicolasHug left a comment •

edited

Loading