[MRG] Add verbose option to Pipeline and FeatureUnion#10435
Closed
jnothman wants to merge 22 commits intoscikit-learn:masterfrom
Closed
[MRG] Add verbose option to Pipeline and FeatureUnion#10435jnothman wants to merge 22 commits intoscikit-learn:masterfrom
jnothman wants to merge 22 commits intoscikit-learn:masterfrom
Conversation
- Each line printed by Pipeline and FeatureUnion, when their verbosity mode is on, will be 70 characters long.
Fix error message bug
Member
Author
|
Apparently I'm testing too strictly... I'll try fix this up later. |
Member
Author
|
reviews welcome here. |
Member
Author
|
Oh no! This has an unpleasant merge conflict with ColumnTransformer. Not sure I'll get around to fixing it soon. It will probably entail making ColumnTransformer support |
Member
|
Here is a way to fix this without supporting Edit: Here is my branch with the merge and fix: master...thomasjpfan:verbose-pipeline |
Member
Author
|
Feel free to open a pull request either to my branch or just a new PR for
the whole thing. Looking at loose commits without CI, commenting and the
ability to extend it into multiple commits is a waste of time.
|
Member
|
Okay! I created a new PR at #11364. |
Member
Author
|
Superseded by #11364 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also add some logging utilities.
Because I was bored of it hanging around after multiple stalled attempts.
Fixes #9668. Fixes #8568. Fixes #5298. Fixes #5321.