Build cp313t linux wheels#7575
Conversation
5c6b14d to
1759d11
Compare
1759d11 to
0c8e8dc
Compare
| call-workflow-build-wheels: | ||
| uses: ./.github/workflows/wheels_recipe.yml | ||
| with: | ||
| CIBW_SKIP: cp313t-* # until Cython 3.1 is released |
There was a problem hiding this comment.
I'm guessing we are still waiting for this before we include the free-threaded build on PyPI?
There was a problem hiding this comment.
It'd be great to follow NumPy, SciPy, scikit-learn et al., and include cp313t wheels in the next releases. This helps the rollout and allows users to start testing. There's no reason one must wait for Cython 3.1 (which is on an uncertain timeline, since it depends on one maintainer with very limited bandwidth).
lagru
left a comment
There was a problem hiding this comment.
Can be merged IMO if the CI passes. Should make free-threaded nightlies available again if I understand things correctly.
|
I can check, but I disabled this because it was blocking the release to PyPI. I will need to double-check to see what wasn't working. |
|
According to my commit message, "Building cp313t wheels requires Cython 3.1, which hasn't been released." I will take a look and see what scipy is doing. |
|
Here is the action failure https://github.com/scikit-image/scikit-image/actions/runs/11204502935/job/31142967402 |
|
That log has disappeared so not sure what went wrong or what changed after the initial PR that added nightly wheels. Here is what NumPy does (and SciPy mirrors that): (1) in the wheel build job, disable build isolation: (2) in that same (3) in the shell script that runs before NumPy, SciPy and PyWavelets all have |
|
Thanks, Ralf! I figured it out yesterday in #7575. Side note: there's a new way of specifying free threaded support now, using options. |
Great! You meant gh-7699 here.
If that's used in gh-7699, did you mean |
|
Sorry, shouldn't respond to these things from a phone; yes, that PR and: |
Description
To merge after 0.25.0 is released. Reverts 07db769.
Checklist
./doc/examplesfor new featuresRelease note
For maintainers and optionally contributors, please refer to the instructions on how to document this PR for the release notes.