Fix 313t wheel build#7699
Merged
jarrodmillman merged 5 commits intoscikit-image:mainfrom Feb 11, 2025
Merged
Conversation
- The pre-release of Cython was installed, but presumably cibuildwheel then re-installed another version; now use CIBW_BUILD_FRONTEND to ensure correct version. - Wheel recipe filename was updated, but still called with old name in nightly-wheel-build.yaml and wheels-test-and-release.yaml - Verbosity was very high, so reduced.
rgommers
reviewed
Feb 9, 2025
rgommers
left a comment
There was a problem hiding this comment.
I assume this isn't mergeable as is yet because it removes the build configs for macOS, Windows and Linux aarch64. The changes to the Linux x86-64 config look good to me though. I reviewed the cp313t build log in detail, and that all looks right.
Capturing a few essential log lines for future reference:
Successfully installed Cython-3.1.0a1 beniget-0.4.2.post1 gast-0.6.0 lazy_loader-0.4 meson-1.7.0 meson-python-0.17.1 numpy-2.3.0.dev0 packaging-24.2 ply-3.11 pyproject-metadata-0.9.0 pythran-0.17.0 setuptools-75.8.0
...
Program python found: YES (/opt/python/cp313-cp313t/bin/python)
...
Created wheel for scikit-image: filename=scikit_image-0.25.2rc0.dev0-cp313-cp313t-linux_x86_64.whl
The only build warnings are -Wunused-value ones from Cython, which will get fixed upstream sooner or later and are harmless.
Member
Author
Ah, yes, the joys of pushing late on a Friday. I added those back in, thanks for the heads-up. |
jarrodmillman
approved these changes
Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested on the
maintenance/fix-313t-wheel-buildbranch