avoid warnings about use of deprecated scipy.linalg.pinv2#5437
Merged
sciunto merged 1 commit intoscikit-image:mainfrom Jun 21, 2021
Merged
avoid warnings about use of deprecated scipy.linalg.pinv2#5437sciunto merged 1 commit intoscikit-image:mainfrom
scipy.linalg.pinv2#5437sciunto merged 1 commit intoscikit-image:mainfrom
Conversation
pyamg uses coarse_solver='pinv2' by default, but SciPy 1.7.0 has deprecated pinv2
jni
approved these changes
Jun 21, 2021
grlee77
added a commit
that referenced
this pull request
Aug 23, 2021
…fix) (#5531) * Backport gh-5529: Handle pooch version 1.5.0 import file_hash from Pooch public API * Backport gh-5437: Avoid use of deprecated scipy.linalg.pinv2 pyamg used coarse_solver='pinv2' by default, but SciPy 1.7.0 has deprecated pinv2 * update version string * DOC: add release notes for 0.18.3 Co-authored-by: Gregory R. Lee <grlee77@gmail.com> Co-authored-by: Mark Harfouche <mark.harfouche@gmail.com> Co-authored-by: David Manthey <david.manthey@kitware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SciPy 1.7.0 is causing a new failure in the CI tests due to a deprecation warning regarding
scipy.linalg.pinv2. We never call this function directly in scikit-image, but thecg_mgoption torandom_walker_segmentationcalls apyamgfunctdion that uses it by default.Here, I change the pyamg call to prefer
pinvrather thanpinv2to avoid the warning.Checklist
./doc/examples(new features only)./benchmarks, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py.doc/release/release_dev.rst.