Backports for 0.18.3 (pooch 1.5 fix, deprecated scipy.linalg.pinv2 fix)#5531
Merged
grlee77 merged 6 commits intoscikit-image:v0.18.xfrom Aug 23, 2021
Merged
Backports for 0.18.3 (pooch 1.5 fix, deprecated scipy.linalg.pinv2 fix)#5531grlee77 merged 6 commits intoscikit-image:v0.18.xfrom
scipy.linalg.pinv2 fix)#5531grlee77 merged 6 commits intoscikit-image:v0.18.xfrom
Conversation
* Handle pooch version 1.5.0 This is compatible with pooch < 1.5.0, too. If such older compatibility is not desired, the dependency version could be changed and just the new code could be kept. * Flip the order in which we try things. * undo typo i introduced * Update skimage/data/__init__.py Co-authored-by: Gregory R. Lee <grlee77@gmail.com> Co-authored-by: Mark Harfouche <mark.harfouche@gmail.com> Co-authored-by: Gregory R. Lee <grlee77@gmail.com>
pyamg uses coarse_solver='pinv2' by default, but SciPy 1.7.0 has deprecated pinv2
Contributor
Author
|
Failures are related to two data files that are getting fetched from the |
scipy.linalg.pinv2 fix)
Contributor
Author
|
As far as I can tell the pooch tests are not going to pass here, but it seems that it should be fine once we have an actual version number that matches a tag. I think I will merge and then follow up, making a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
import
file_hashfrom Pooch public APIscipy.linalg.pinv2#5437 (SciPy v1.7.x compatibility)use
pinvinstead of deprectedscipy.linalg.pinv2inrandom_walkerChecklist
./doc/examples(new features only)./benchmarks, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py.doc/release/release_dev.rst.