Skip to content

Debug failure with pytest-dev#120

Merged
pllim merged 6 commits intoscientific-python:masterfrom
saimn:pytest-6.0.0
Jul 29, 2020
Merged

Debug failure with pytest-dev#120
pllim merged 6 commits intoscientific-python:masterfrom
saimn:pytest-6.0.0

Conversation

@saimn
Copy link
Copy Markdown
Contributor

@saimn saimn commented Jul 29, 2020 •
edited by pllim
Loading

ref and close #119

fix #118

(edited)

@saimn
Copy link
Copy Markdown
Contributor Author

saimn commented Jul 29, 2020

Hmm, pip freeze's output is interesting:

['attrs==19.3.0',
 'certifi==2020.6.20',
 'iniconfig==1.0.0',
 'more-itertools==8.4.0',
 'packaging==20.4',
 'pluggy==0.13.1',
 'py @ file:///tmp/build/80754af9/py_1593446248552/work',
 'pyparsing==2.4.7',
 'pytest @ '
 'git+https://github.com/pytest-dev/pytest.git@d756b4a5432bddcae26869ff902ca9457fe59f8c',
 'pytest-doctestplus @ file:///home/travis/build/astropy/pytest-doctestplus',
 'six==1.15.0',
 'toml==0.10.1',
 'wcwidth @ file:///tmp/build/80754af9/wcwidth_1593447189090/work']

@saimn
Copy link
Copy Markdown
Contributor Author

saimn commented Jul 29, 2020

@pllim : I see green ! Btw, I took your commit from the other PR.

@pllim pllim added 🔥 Critical bug labels Jul 29, 2020
pllim
pllim approved these changes Jul 29, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why there is a need to support Python 3.4 or older back in #78. Definitely doesn't seem necessary given:

https://github.com/astropy/pytest-doctestplus/blob/4028a7673ac323842dce09dbb054996c90cc91de/setup.py#L42

Thanks for the fix!

@pllim pllim merged commit 44cc6d1 into scientific-python:master Jul 29, 2020
This was referenced Jul 29, 2020
Closed
Closed
Closed
@saimn saimn deleted the pytest-6.0.0 branch July 29, 2020 20:34
lpsinger added a commit to lpsinger/pytest-doctest-ufunc that referenced this pull request Jul 31, 2020
@lpsinger
Fix compatibility with pytest 6.0.0
9374cf7 
Adapted from scientific-python/pytest-doctestplus#120.
lpsinger added a commit to lpsinger/ligo.skymap that referenced this pull request Jul 31, 2020
@lpsinger
Pin pytest<6
5563df8 
We are waiting for a release of pytest-doctestplus that will fix
an issue with compatibility with pytest 6.0.0.

See scientific-python/pytest-doctestplus#120.
@karllark karllark mentioned this pull request Jul 31, 2020
Merged
@matteobachetti matteobachetti mentioned this pull request Jul 31, 2020
Merged
lpsinger added a commit to lpsinger/ligo.skymap that referenced this pull request Aug 2, 2020
@lpsinger
Revert "Pin pytest<6"
e17b95b 
The upstream compatibility issue in pytest-doctestplus
(scientific-python/pytest-doctestplus#120)
has been fixed by a new release.

This reverts commit ac4560c
and 5563df8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pllim pllim pllim approved these changes

Assignees

No one assigned

Labels

bug 🔥 Critical

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing importmode with pytest 6.0.0

2 participants

@saimn @pllim