allow to specify module version doctest-requires sphinx directive#78
Merged
bsipocz merged 4 commits intoscientific-python:masterfrom Nov 6, 2019
Conversation
bsipocz
approved these changes
Nov 5, 2019
Member
bsipocz
left a comment
There was a problem hiding this comment.
Minor nitpicking, otherwise looks like a great improvement!
Member
|
Thank you @vanyakosmos! |
Contributor
|
Is there a new release with this patch? |
Contributor
|
Could use the fix for #29 in astropy/astropy#7928 |
Member
|
@pllim - I can make a release over the weekend, along with helpers, etc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #57
close #29
close #18
Note 1 - split regex
Old regex
\s*,?\s*used in re.split produces['s', 'y', 's']from string'sys'.New regex
\s*[,\s]\s*:Note 2 - getting package versions
For python3.4+ there is
pkg_resources.requireto check that package with specified version is available.For python2 (which should be already dropped) I wrote custom version checker which essentially just pull packages info from
pip freezeoutput and compare versions usingdistutils.version.LooseVersion.pip freezeis triggered only for python3.4-.