Handle mixed file types in drag & drop operations#247
Merged
Conversation
Remove unused draggingEntered method and update performDragOperation to properly handle mixed content when dragging multiple files. Images are inlined as base64 data URLs, textClipping content is extracted and inserted, and other files have their paths inserted. Related to #245
Contributor
Code Coverage ReportCurrent Coverage: 51.44% Coverage Details (Summary) |
Merged
schuyler
pushed a commit
that referenced
this pull request
Jan 16, 2026
This uses code from #247 and shuffles code out of MPEditorView since it began to look a bit crowded there. Tested it, worked fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
draggingEnteredmethod (confirmed dead code per testing feedback)performDragOperation:to properly handle mixed content when dragging multiple files:This addresses the edge case where dragging a mix of textClipping and image files would silently discard the textClippings.
Test plan
Related to #245