Merged
Conversation
Owner
|
@wltb thanks for this! Looks like there are some conflicts with changes to main. You want to fix or should I take a whack at it? |
Contributor
Author
f72a3b9 to
3799376
Compare
Owner
|
Hmm, tests are still failing in CI. I'll have to download this locally and see if I can figure out why. |
added 2 commits
January 15, 2026 23:28
…ng as fallback behavior. Created new class for this and moved code to it.
3799376 to
9e9fdc0
Compare
Contributor
Author
|
@schuyler My bad, I only tested drag & drop functionality and didn't run the unit tests. The tests for EditorView failed because I removed the called methods in the class. I removed the EditorView test file, and added one for the new class. Fewer tests are needed now because the new class method only returns MIME types, so testing for UTIs and integration can't be done anymore. If you want those back, I can refactor again, but I don't think the code will be likely to break. |
9e9fdc0 to
920b7c7
Compare
Owner
|
Merged. Thank you!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses code from #247 and shuffles code out of MPEditorView since it began to look a bit crowded there.
Tested it, worked fine.