Composite pricing, updated (supersedes #830)#994
Merged
danbri merged 5 commits intoschemaorg:sdo-deimosfrom Mar 18, 2016
Merged
Composite pricing, updated (supersedes #830)#994danbri merged 5 commits intoschemaorg:sdo-deimosfrom
danbri merged 5 commits intoschemaorg:sdo-deimosfrom
Conversation
18 tasks
| <div itemscope itemtype="http://schema.org/Offer"> | ||
| <h1 itemprop="description">Our Private Bank Account Package: Low monthly fees and fair per-use charges.</h1> | ||
| <b itemprop="name">Private Bank Account Package</b> | ||
| <span itemprop="itemOffered" itemscope itemtype="BankAccount"> |
Contributor
There was a problem hiding this comment.
The itemtype value must be an absolute URL.
danbri
added a commit
that referenced
this pull request
Mar 18, 2016
Composite pricing, updated (supersedes #830)
Contributor
Contributor
|
I submitted a PR for the mentioned fixes as well as two fixes for issues I didn’t notice when reviewing it the first time: #1038 |
Contributor
Author
|
Thanks!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates #830. It adds examples for two domains and addresses the issue described in #829.
CompoundPriceSpecification is a needed enhancement from GoodRelations for cases in which a price consists of multiple components (e.g. 50 USD per day and 0.10 USD per mile for a rental car).