Composite pricing examples: various fixes#1038
Merged
danbri merged 2 commits intoschemaorg:sdo-deimosfrom Mar 19, 2016
Merged
Conversation
Contributor
Author
|
By the way, the used type |
Contributor
|
This is part of the FIBO proposal #965. We could replace the type in the example in order to remove this dependency. |
danbri
added a commit
that referenced
this pull request
Mar 19, 2016
Composite pricing examples: various fixes
Contributor
|
Thanks @unor :) Merged, but let's change that example while the FIBO stuff awaits a bit more discussion - but what can we change it to? |
Contributor
Author
|
As |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed the points mentioned in #994 (
itemtyp→itemtype; absolute URL value foritemtypeattribute; missing</span>) and:</div>, which lead to parsing errorspriceComponentproperty instead of using an array, which lead to parsing errors (please review if I used the array correctly, as I don’t know JSON-LD very well)