Conversation
7180f06 to
7ce8a1e
Compare
Anyone who doesn't understand why result printing was turned off after they entered `:silent` mode will start the REPL with `-Dscala.repl.debug` and be enlightened. For infotainment purposes, the verbose message is also emitted under info mode.
7ce8a1e to
3a3ecb2
Compare
|
You shall pass, once the build does! |
|
/cc @dragos since this checks of the first customization mentioned in #4563 (comment) |
3a3ecb2 to
09caa99
Compare
|
It turns out that it's called BC test because it exists to make sure we're stuck in the Stone Age. I accidentally enabled Would also be nice if unit tests ran before BC. Usually BC is incidental and workaroundable, but failing tests are meaningful at least 50% of the time. I'll work in a coffee break to get back to this today, in lieu of foosball. |
|
good point regarding the order of tests -- tracked as scala/scala-jenkins-infra#81 |
Can be specified by `-Dscala.repl.welcome=Greeting` or in properties file. It takes the same format arguments as the prompt, viz, version, Java version and JVM name. It can be disabled by `-Dscala.repl.welcome` with no text.
Specify it with -Dscala.shell.histfile=/path/to/file.
Because who doesn't want to customize their continuation prompt? `scala -Dscala.repl.continue="..."` looks especially nice with `-Dscala.color`. Somewhat works when pasting, but the test rig for running a transcript does not seek to support custom secondary prompts.
09caa99 to
eab44dd
Compare
|
OMG, it passed. Sorry it didn't make 2.11.7. Wink, wink. |
|
How about 2.11.7-1? |
|
Is there a 2.11.7-2015-06-23-2050? |
|
Does Jenkins, diligent though he may be, check that all authors have signed CLA or only the PR submitter? Does he check whether the signator is just a shell corporation in the Cayman Islands? |
|
Looks like it is based on the PR submitter, not the commit author. That code also seems deficient with regards to the KYC principles of the anti-code-laundering regulators. |
|
hey, I didn't at-sign retronym, but he is one of my favorite Scala dads. I wonder if he has a dog, because Friday is Take your dog to work day. I wonder if Miles Shapeless is aware of that. He must be. |
|
I think in his part of the world, that is statically overridden by the the spaniels' take-your-owner-to-the-rolling-green-hills friday. |
Everyone knows that a `help` command will result in `more information`. This commit moves the version string to the second line and adds some verve to the welcome. If anyone can't live without the old banner, they are now able to configure it explicitly, so there is still no blood on our hands. ``` $ scala Welcome to Scala version 2.11.6 (Java HotSpot(TM) 64-Bit Server VM, Java 1.8.0_40). Type in expressions to have them evaluated. Type :help for more information. scala> :quit $ skala Welcome to Scala! version 2.11.7-20150623-155244-eab44dd092 (Java HotSpot(TM) 64-Bit Server VM, Java 1.8.0_40). Type in expressions for evaluation. Or try :help. scala> :quit ``` REPL tests now lop off the actual length of the welcome header; or, if necessary, remove the version number from a header embedded in output.
The welcome message defaults to a sober header followed by one line of instructions.
83ff5b5 to
fac81d7
Compare
|
Looks good as far as I'm concerned. |
|
I might go retro. |
|
I'd drop articles. |
|
LGTM. @adriaanm, not sure if your comment is a joke I'm missing, or what. |
|
|
Yep, silly jokes is my middle name. |
|
Where others use |
|
(How would a group nap help us find anything? Oh wait, I'm losing my dutch!) |
|
I have just tested with scala-2.11.8-d792e35-nightly.tgz. Option -Dscala.repl.continue is taken into account but also prepended with two spaces. Thank you for your work on these points. |
|
@iracic the code comment says continue prompt is adjusted for your primary prompt. So the code lines up. |
|
Personally I do not see the need for such rule. |
|
The idea was that the common use case is to set the primary prompt and see aligned output. Dynamic prompts are any length. I could see not aligning if both prompts are user-supplied. Or a different flag for it. Maybe ask on gitter and create an issue. |
|
Thanks again for pushing this stuff forward. |
|
So Ammonite has the bang from my original edit! No wonder everyone loves Ammonite! |
This supersedes #4447 and considers 2.11.x...iracic:topic/repl-customization--2nd-try
Introduces
scala.repl.continuefor continuation prompt,scala.shell.histfilefor history file location, andscala.repl.welcomefor its first impression, which is also available as a properties file entry,shell.welcome.The welcome banner is turned off by setting it empty.
Review by @adriaanm the gaatkeeper.