Conversation
|
Welcome & thank you, @iracic! Please sign the Scala CLA. |
There was a problem hiding this comment.
Wouldn't this break existing customizers? I don't think we can afford to do that, sorry.
There was a problem hiding this comment.
You are right, I was too fast here.
I propose to keep this one and also try to change namespace as "scala.shell." on other properties in the same way.
I will rework/rename these and try again (should I go with new PR) ?
There was a problem hiding this comment.
I have created another branch topic/repl-customization--2nd-try.
Let me know your opinion about it.
Thank you.
There was a problem hiding this comment.
Ok, please push --force to the same branch so that this PR is updated.
There was a problem hiding this comment.
Ok, will do forced push.
Adriaan, do you prefer to squash to one change ?
f99e1be to
5a1e437
Compare
|
Yes, please squash to one commit, and take a look at the guidelines around formatting your commit message (short title that can be included in release notes, description in body, reference to jira ticket if any,...). Here's a rough suggestion for the title: "Configurable REPL: prompt, verbosity, history path". |
5a1e437 to
b31281e
Compare
|
Squashed. Thank you. |
|
There are also various places where the change introduced odd formatting, this should be fixed, too. |
|
I think my previous comments about formatting and using In anticipation, I have prepared a StackOverflow answer to "How do I set the history file for REPL?" |
b31281e to
7c5bddf
Compare
|
Tried to reformat code and put properties in ReplProps |
|
Above failure seem like infrastructure errors. I do not find link between them and code changes... |
|
You're right, it's not related to your changes. We're looking at these problems. |
|
@mpociecha Thank you |
|
@iracic Simply I'm a culprit. |
|
@mpociecha Shame on you :-) |
There was a problem hiding this comment.
prompt2 should be renamed to something more descriptive
There was a problem hiding this comment.
I thought that "suffix" 2 make sense (similar to PS2 in Unix shell)
Let me know what do you propose ?
The scala shell prompt can be provided as either a system property or in compiler.properties. The prompt string is taken as a format string with one argument that is the version string. ``` $ scala -Dscala.repl.prompt="%nScala %s> " Welcome to Scala version 2.11.7-20150616-093756-43a56fb5a1 (Java HotSpot(TM) 64-Bit Server VM, Java 1.8.0_45). Type in expressions to have them evaluated. Type :help for more information. Scala 2.11.7-20150616-093756-43a56fb5a1> 42 res0: Int = 42 Scala 2.11.7-20150616-093756-43a56fb5a1> :quit ```
|
superseded by #4576 |
Few low hanging fruit changes to customize scala REPL.
Please, let me know if anything should be improved.