Skip to content

2.13: new Scala SHA#1384

Closed
SethTisue wants to merge 7 commits intoscala:2.13.xfrom
SethTisue:new-scala-sha-20210311
Closed

2.13: new Scala SHA#1384
SethTisue wants to merge 7 commits intoscala:2.13.xfrom
SethTisue:new-scala-sha-20210311

Conversation

@SethTisue
Copy link
Copy Markdown
Member Author

FAILURES (UNEXPECTED): scalameta,blaze,scalafx

two now-illegal overrides, one reporter thing

@SethTisue
Copy link
Copy Markdown
Member Author

SethTisue commented Mar 13, 2021

the scalameta failure is a source incompatibility caused by scala/scala#9449, which adds a parameter to reportSuspendedMessages that wasn't there before

@SethTisue
Copy link
Copy Markdown
Member Author

SethTisue commented Mar 13, 2021

@lrytz I'd like not to spend time on this, so I can focus on other tasks. can I ask you to either make the needed changes to scalameta upstream, or explain to the scalameta maintainers what they need to do?

there is a semanticdb/scalac/library/src/main/scala-2.13.5 which has a VersionCompilerOps.scala that handles calling reportSuspendedMessages. looks like there will need to be a 2.13.6 directory as well with different code, but if the reportSuspendedMessages needs a Run, it wasn't immediately clear to me at the call sites where I would get that Run. (but I didn't look very hard.)

@SethTisue
Copy link
Copy Markdown
Member Author

superseded by #1392

@SethTisue SethTisue closed this Mar 26, 2021
@SethTisue SethTisue mentioned this pull request Mar 26, 2021
@lrytz
Copy link
Copy Markdown
Member

lrytz commented Mar 29, 2021

@SethTisue the fix should be trivial: forceWarnings should again be a no-op for 2.13.6, as it is for 2.13.1 (https://github.com/scalameta/scalameta/blob/master/semanticdb/scalac/library/src/main/scala-2.13.1/scala/meta/internal/semanticdb/scalac/VersionCompilerOps.scala).

I'm not sure how exactly what you need to do in order to make it work in the community build, until 2.13.6 is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants