Skip to content

2.13: new Scala SHA#1392

Merged
SethTisue merged 5 commits intoscala:2.13.xfrom
SethTisue:new-scala-2.13-sha-20210325
Mar 30, 2021
Merged

2.13: new Scala SHA#1392
SethTisue merged 5 commits intoscala:2.13.xfrom
SethTisue:new-scala-2.13-sha-20210325

Conversation

@SethTisue
Copy link
Copy Markdown
Member

@SethTisue SethTisue commented Mar 26, 2021 •
edited
Loading

@SethTisue SethTisue self-assigned this Mar 26, 2021
@SethTisue SethTisue mentioned this pull request Mar 26, 2021
Closed
@SethTisue
Copy link
Copy Markdown
Member Author

SethTisue commented Mar 26, 2021 •
edited
Loading

this has the same Scalameta failure I described at #1384 (comment) — it has to do with the reportSuspendedMessages change in scala/scala#9449

@lrytz you didn't respond to that — are you planning on looking into this, or do you want me to deal with it myself?

@lrytz
Copy link
Copy Markdown
Member

lrytz commented Mar 26, 2021

I missed it last time, sorry. Will take a look next week.

@SethTisue
Copy link
Copy Markdown
Member Author

SethTisue commented Mar 29, 2021 •
edited
Loading

Lukas writes:

the fix should be trivial: forceWarnings should again be a no-op for 2.13.6, as it is for 2.13.1 (https://github.com/scalameta/scalameta/blob/master/semanticdb/scalac/library/src/main/scala-2.13.1/scala/meta/internal/semanticdb/scalac/VersionCompilerOps.scala).

I'm not sure how exactly what you need to do in order to make it work in the community build, until 2.13.6 is out.

@SethTisue SethTisue mentioned this pull request Mar 29, 2021
Merged
@SethTisue
Copy link
Copy Markdown
Member Author

SethTisue commented Mar 29, 2021

@lrytz that did it. thanks!

@SethTisue
Copy link
Copy Markdown
Member Author

SethTisue commented Mar 30, 2021 •
edited
Loading

one more failure: blaze

[blaze] [error] /home/jenkins/workspace/scala-2.13.x-jdk11-integrate-community-build/target-0.9.17/project-builds/blaze-5f5ec77ce1f780dd59b6304759401718f47295bc/http/src/main/scala/org/http4s/blaze/http/http1/server/Http1ServerParser.scala:37:26: weaker access privileges in overriding
[blaze] [error] def submitRequestLine(methodString: String, path: String, scheme: String, majorVersion: Int, minorVersion: Int): Boolean (defined in class Http1ServerParser)
[blaze] [error]   override should be public
[blaze] [error]   override protected def submitRequestLine(
[blaze] [error]                          ^

which I recall already hitting when we did a trial CB run before merging scala/scala#9525 . it should work to just fork it and make the needed source adjustment

@SethTisue SethTisue mentioned this pull request Mar 30, 2021
Merged
@SethTisue
Copy link
Copy Markdown
Member Author

SethTisue commented Mar 30, 2021 •
edited
Loading

now http4s is running afoul of scala/scala#9336:

[http4s] [error] /home/jenkins/workspace/scala-2.13.x-jdk11-integrate-community-build/target-0.9.17/project-builds/http4s-d35ab4a78b2b5b39eee74c29418609e7bdf5238f/core/src/main/scala/org/http4s/multipart/Part.scala:33:9: annotation argument needs to be a constant; found: scala.Predef.augmentString("Empty parts are not allowed by the multipart spec, see: https://tools.ietf.org/html/rfc7578#section-4.2\n       Moreover, it allows the creation of potentially incorrect multipart bodies\n    ").stripMargin
[http4s] [error]     """.stripMargin,
[http4s] [error]         ^
[http4s] [error] one error found
[http4s] [error] /home/jenkins/workspace/scala-2.13.x-jdk11-integrate-community-build/target-0.9.17/project-builds/http4s-d35ab4a78b2b5b39eee74c29418609e7bdf5238f/core/src/main/scala/org/http4s/multipart/Part.scala:33:9: annotation argument needs to be a constant; found: scala.Predef.augmentString("Empty parts are not allowed by the multipart spec, see: https://tools.ietf.org/html/rfc7578#section-4.2\n       Moreover, it allows the creation of potentially incorrect multipart bodies\n    ").stripMargin
[http4s] [error]     """.stripMargin,
[http4s] [error]         ^

but it's an easy fix

@SethTisue SethTisue merged commit 24d2e83 into scala:2.13.x Mar 30, 2021
@SethTisue SethTisue deleted the new-scala-2.13-sha-20210325 branch March 30, 2021 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@SethTisue SethTisue

Labels

contents: Scala SHA

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SethTisue @lrytz