Store suspended warnings per compilation unit#9449
Merged
dwijnand merged 2 commits intoscala:2.12.xfrom Mar 3, 2021
Merged
Conversation
Member
|
@lrytz could there be test coverage? the regression this fixes is pretty significant |
Member
Author
|
Yes I'll come up with a test. |
This comment has been minimized.
This comment has been minimized.
Store suspended warnings per compilation unit and report them in `typerPhase.apply(unit)` instead of `typerPhase.run` - the latter is not invoked when using the presentation compiler.
Index suspended warnings by SourceFile. Test case for issue 12308.
dwijnand
approved these changes
Mar 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store suspended warnings per compilation unit and report them
in
typerPhase.apply(unit)instead oftyperPhase.run- the latteris not invoked when using the presentation compiler.
Fixes scala/bug#12308