Merged
Conversation
... not exitingPostErasure, as this phase-travel crashes the compile (it's only really meant for going back in time, right?)
|
Can one of the admins verify this patch? |
Member
|
Fix should target 0.13.10 branch. In this case we should be able to automatically merge, but 0.13 can move ahead. |
eed3si9n
added a commit
that referenced
this pull request
Jan 24, 2016
This was referenced Jan 25, 2016
This was referenced Jan 26, 2016
Member
|
Should this be forward ported? |
Member
|
I guess this is superseded by sbt/zinc#95 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the breakage introduced in #2261.
The fix comes from @adriaanm who suggested to use
transformedTyperatherexitingPostErasureto inspect types after erasure in scala/scala@6dd1495.I can confirm that with this PR applied, these builds now pass:
https://travis-ci.org/xuwei-k/Play20/jobs/104261656#L497
https://travis-ci.org/seratch/skinny-framework/jobs/104275385#L2107
https://travis-ci.org/xuwei-k/cats/jobs/104294044#L2702
Fixes #2411