Skip to content

(Don't merge yet) Revert 4605802#2416

Closed
eed3si9n wants to merge 2 commits intosbt:0.13.10from
eed3si9n:wip/2411
Closed

(Don't merge yet) Revert 4605802#2416
eed3si9n wants to merge 2 commits intosbt:0.13.10from
eed3si9n:wip/2411

Conversation

@eed3si9n
Copy link
Member

Revert 4605802. Fixes #2411. Ref #1171

/review @Duhemm, @dwijnand

@dwijnand
Copy link
Member

Sad days. LGTM.

@smarter
Copy link
Contributor

smarter commented Jan 24, 2016

After applying #2414, the test case in eed3si9n@1f25cdf compiles and run successfully, however I was able to reproduce the problem by changing the testcase to involve a derived value class:

package example

class VC(val self: Int) extends AnyVal

class A {
  case class B(x: VC)
  def c = B
}
object A {
  def main(args: Array[String]): Unit = {
    (new A).c
  }
}

I suggest using this as a testcase instead. I can't help with the actual bug but my guess is that it has something to do with exitingPostErasure and scala/scala@6dd1495 might help, cc @adriaanm

Duhemm added a commit to Duhemm/sbt that referenced this pull request Jan 24, 2016
@Duhemm
Copy link
Contributor

Duhemm commented Jan 24, 2016

It looks like using the changes in scala/scala@6dd1495 fixes the issue for both test cases in this ticket. Do we want to revert #2261 altogether or apply the fix by @adriaanm?

I created a branch with the test cases and the fix by @adriaanm: 0.13...Duhemm:fix-2411

@eed3si9n
Copy link
Member Author

@eed3si9n eed3si9n changed the title Revert 4605802 (Don't merge yet) Revert 4605802 Jan 24, 2016
@Duhemm
Copy link
Contributor

Duhemm commented Jan 24, 2016

@eed3si9n Of course.

@dwijnand
Copy link
Member

If possible please forward fix. Reverts are more work in this forward-porting, multi-repo world.

@eed3si9n
Copy link
Member Author

Closing this in favor of #2418

@eed3si9n eed3si9n closed this Jan 25, 2016
@eed3si9n eed3si9n deleted the wip/2411 branch January 25, 2016 01:56
Duhemm added a commit to sbt/zinc that referenced this pull request Jan 25, 2016
Duhemm added a commit to Duhemm/incrementalcompiler that referenced this pull request Feb 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants