Don't pass -J<flag> to local java, improve javac's error parsing#2272
Merged
Don't pass -J<flag> to local java, improve javac's error parsing#2272
-J<flag> to local java, improve javac's error parsing#2272Conversation
These options can only be given to a forked Java compiler. If we run a local java compiler, we filter these options out and emit a warning. Fixes sbt#1968
Upon startup, javac may report errors because (for instance) because it received incorrect flags. These errors were not correctly parsed by the JavaErrorParser and were never reported to the user. This commit fixes this problem by adding a new parsing rule in JavaErrorParser: errors that start with the prefix "javac:" are now correctly parsed and reported to the user. Fixes sbt#2256
|
Can one of the admins verify this patch? |
Member
|
LGTM (for what I can see, not what I know :D) |
Member
|
LGTM pending Travis |
eed3si9n
added a commit
that referenced
this pull request
Nov 27, 2015
Don't pass `-J<flag>` to local java, improve javac's error parsing
eed3si9n
added a commit
to sbt/zinc
that referenced
this pull request
Dec 7, 2015
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides a fix for #1968 by not passing
-J<flag>options to the local Java compiler and emitting a warning.It also fixes #2256. Error messages were not displayed because they were not correctly parsed by
JavaErrorParser.