Report failed compilation if errors are registered.#2271
Merged
Conversation
In some cases, the local java compiler may report compilation errors, but succeed in compiling the source files (for instance, if there are encoding problems in the source). However, the command line javac will report a failed compilation on the same input. To have the local java compiler behave like the forked java compiler, we now report the compilation as failed if error messages have been registered during compilation. Fixes sbt#2228
|
Can one of the admins verify this patch? |
Member
|
LGTM (for what I can see, not what I know :D) |
eed3si9n
added a commit
that referenced
this pull request
Nov 12, 2015
Report failed compilation if errors are registered.
eed3si9n
added a commit
to sbt/zinc
that referenced
this pull request
Dec 7, 2015
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases, the local java compiler may report compilation errors,
but succeed in compiling the source files (for instance, if there are
encoding problems in the source). However, the command line javac will
report a failed compilation on the same input.
To have the local java compiler behave like the forked java compiler, we
now report the compilation as failed if error messages have been
registered during compilation.
Fixes #2228