IVY-1526 Use parent pom's license (if any) if the child pom doesn't e…#14
IVY-1526 Use parent pom's license (if any) if the child pom doesn't e…#14
Conversation
…xplicitly have licenses of its own Conflicts: test/java/org/apache/ivy/plugins/parser/m2/PomModuleDescriptorParserTest.java
|
Hi @jaikiran, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Typesafe Contributors License Agreement: |
|
@jaikiran Ignore the typesafehub validator. Thanks for the fix to apache Ivy, we may be pulling that in ourselves quickly. See my notes for some caveats to the fix, and thanks for the hard work! |
|
LGTM |
|
The build history on Travis looks pretty bloody - https://travis-ci.org/sbt/ivy/builds |
|
@eed3si9n If you let me know which one is flaky, sure. I know locally, the tests try to hit a domain that doesn't exist and my ISP is providing its own 404 pages with advertisements, whereas the test expects an actually 404. Perhaps this is one you should run locally too to verify my work. |
|
I wasn't sure if we wanted to wait for the upstream fix (apache/ant-ivy#7) to be merged, but otherwise looks good |
|
@eed3si9n I disabled the flaky test suites. Not sure in junit how to disable just the flaky test without removing it completely. Not sure we really want to disable Ibiblio tests generally, just teh one that tries to hit an invalid URL/domain name. |
|
@benmccann we're already running with patches above/beyond that in mainstream, so I'm ok merging this as is. I did a review of the code and it looks fine. |
|
Any tests that have failed or errored frequently are candidates for disabling, so we can actually catch regressions. https://travis-ci.org/sbt/ivy/builds/35535652: |
|
Ok, build is now working. |
IVY-1526 Use parent pom's license (if any) if the child pom doesn't e…
|
Merged! |
|
awesome. thanks guys! |
|
Thank you very much @jsuereth, for merging this. I'll wait on the ivy dev team to merge it to ivy upstream too. |
|
Is this change in sbt 0.13.9? I just tried it and it doesn't seem like it's working yet |
…xplicitly have licenses of its own
A backport of license fixes for sbt's Ivy 2.3.
Notes:
Related to sbt/sbt#2118
Review by @eed3si9n cc @benmccann