IVY-1526 Use parent pom's license (if any) if the child pom doesn't explicitly have its own#7
Closed
jaikiran wants to merge 1 commit intoapache:masterfrom
jaikiran:master
Closed
IVY-1526 Use parent pom's license (if any) if the child pom doesn't explicitly have its own#7jaikiran wants to merge 1 commit intoapache:masterfrom jaikiran:master
jaikiran wants to merge 1 commit intoapache:masterfrom
jaikiran:master
Conversation
…xplicitly have licenses of its own
|
Awesome. Thank you so much for this fix |
|
Just a reminder to please review this pull request. Thanks! |
|
FYI - We ran this on sbt/ivy and it looks great! I backported to Ivy 2.3 and it'll be available to sbt users shortly. Great work on teh fix! Also, nice catch on the test suite fix. |
|
Ping. Please review! :-) |
Member
Author
|
@benmccann I haven't heard any inputs on the mailing list nor here, from the Ivy dev team. Not sure how active the project is. |
Contributor
|
Merged. Thank you for the pull request. Sorry for the delay. |
|
Thanks!! |
Member
Author
|
Thanks @nlalevee for merging this. Glad to see the contribution being accepted. Will send out PRs for other issues that I have started looking into. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit here fixes the issue reported in https://issues.apache.org/jira/browse/IVY-1526.
Maven, natively, uses the parent pom's license if the child project doesn't specify its own licenses in the pom.xml [1]. The commit here does a change which behaves similarly when Ivy is resolving a Maven dependency - the parent's licenses are applied on the module descriptor if the module itself doesn't specify its licenses.
The commit also includes a couple of new tests to verify this change.
[1] http://www.mail-archive.com/users%40maven.apache.org/msg125044.html - Trying this against a sample parent/child Maven projects does show that the parent pom's license is used in the absence of any licenses in the child project.