Merged
Conversation
jamesnw
commented
Sep 26, 2023
proposal/package-importer.d.ts.md
Outdated
| * If any object in `options.importers` is exactly equal to the object | ||
| `nodePackageImporter`: | ||
|
|
||
| * If the execution environment is the browser, throw an error. |
Contributor
Author
There was a problem hiding this comment.
@nex3 Is a more formal way needed to specify the execution environment?
Contributor
There was a problem hiding this comment.
I think this is fine, although it might be slightly more accurate to say "if no filesystem is available" in case this is run in a different kind of sandboxed JS environment.
nex3
approved these changes
Sep 27, 2023
jgerigmeyer
added a commit
to oddbird/sass
that referenced
this pull request
Oct 12, 2023
* main: Remove `isAlphaMissing` and add "alpha" to channel name types. Rename types using title-case for acronyms longer than two letters in camel-case identifiers. Clarifying performance expectations about sass and sass-embedded (sass#3716) Tweak language around getters and arrays. Code review Remove unused ValueObject type [First-Class Mixins] Flush to spec Move and restructure how we specify scopes Fix typos in the deprecation APi proposal (sass#3708) Return immutable types Remove generic change overload Add first class mixins to embedded sass protobuf and JS API (sass#3674) Draft 1.1 changes for Color spaces JS API (sass#3704) Add support for the relative color syntax from CSS Color 5 (sass#3676) Bump tj-actions/changed-files from 39.0.3 to 39.2.0 (sass#3697) Package Importer updates (sass#3699) Fix link in Contributing docs (sass#3705)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Throw an error if
nodePackageImporteris used in the browser.Remove specified order in the global import list, as users can specify the
order within the
importersoption.Closes #3701