Add support for the relative color syntax from CSS Color 5#3676
Merged
Add support for the relative color syntax from CSS Color 5#3676
Conversation
nex3
approved these changes
Sep 6, 2023
Contributor
|
Spec changes look good, but per the fast track process this should be landed along with patches to Dart Sass and the tests. |
Contributor
Author
|
@nex3 I have the dart-sass change in progress locally. I will open the PR soon. |
This was referenced Sep 27, 2023
8870ea0 to
49407f2
Compare
Contributor
Author
|
@nex3 PRs for sass-spec and dart-sass are now ready |
When using the relative color syntax, the color function is emitted as a CSS function (similar to cases using a CSS variable in arguments).
49407f2 to
1709d86
Compare
Contributor
Author
|
@nex3 as you merged the implementation in dart-sass, I think this should be merged as well. |
jgerigmeyer
added a commit
to oddbird/sass
that referenced
this pull request
Oct 12, 2023
* main: Remove `isAlphaMissing` and add "alpha" to channel name types. Rename types using title-case for acronyms longer than two letters in camel-case identifiers. Clarifying performance expectations about sass and sass-embedded (sass#3716) Tweak language around getters and arrays. Code review Remove unused ValueObject type [First-Class Mixins] Flush to spec Move and restructure how we specify scopes Fix typos in the deprecation APi proposal (sass#3708) Return immutable types Remove generic change overload Add first class mixins to embedded sass protobuf and JS API (sass#3674) Draft 1.1 changes for Color spaces JS API (sass#3704) Add support for the relative color syntax from CSS Color 5 (sass#3676) Bump tj-actions/changed-files from 39.0.3 to 39.2.0 (sass#3697) Package Importer updates (sass#3699) Fix link in Contributing docs (sass#3705)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the relative color syntax, the color function is emitted as a CSS function (similar to cases using a CSS variable in arguments).
This fast track proposal updates the definition of the
rgbandhslglobal functions. The proposal for color spaces is also updated to reflect the new parsing.#3673