[Calc Functions] Match the spec's behavior better for percentages#3630
Merged
[Calc Functions] Match the spec's behavior better for percentages#3630
Conversation
More functions disallow percentages in CSS than our spec did, so this updates the spec to match.
Contributor
Author
jathak
approved these changes
Jul 6, 2023
Known incompatibilities are definitely a problem even if we can't resolve the rest of the function.
jathak
approved these changes
Jul 7, 2023
jgerigmeyer
added a commit
to oddbird/sass
that referenced
this pull request
Jul 13, 2023
* main: [Calculation API] Fix some issues brought up during implementation (sass#3631) Bump tj-actions/changed-files from 37.0.5 to 37.1.0 (sass#3632) [Calc Functions] Match the spec's behavior better for percentages (sass#3630) Bump tj-actions/changed-files from 37.0.2 to 37.0.5 (sass#3627) Fix a reference to a dead link (sass#3625)
jgerigmeyer
added a commit
to oddbird/sass
that referenced
this pull request
Aug 7, 2023
* main: Bump tj-actions/changed-files from 37.4.0 to 37.5.1 (sass#3643) [First-Class Mixins] Create a proposal (sass#3626) [Calc Functions] Fix the definition of rem() (sass#3641) Bump tj-actions/changed-files from 37.1.2 to 37.4.0 (sass#3640) [Color 4] Clarify in Known Color Spaces that lightness is clamped (sass#3639) Add JS type definitions for calculations (sass#3622) Bump tj-actions/changed-files from 37.1.0 to 37.1.2 (sass#3635) [Calculation API] Fix some issues brought up during implementation (sass#3631) Bump tj-actions/changed-files from 37.0.5 to 37.1.0 (sass#3632) [Calc Functions] Match the spec's behavior better for percentages (sass#3630) Bump tj-actions/changed-files from 37.0.2 to 37.0.5 (sass#3627) Fix a reference to a dead link (sass#3625)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More functions disallow percentages in CSS than our spec did, so this
updates the spec to match.