Proposal for First Class Mixins: Draft 1#3626
Merged
Conversation
nex3
requested changes
Jul 6, 2023
Contributor
nex3
left a comment
There was a problem hiding this comment.
Thanks for taking a stab at this! This would be a very nice bread-and-butter feature to land.
connorskees
commented
Jul 7, 2023
nex3
requested changes
Jul 7, 2023
Contributor
nex3
left a comment
There was a problem hiding this comment.
This still needs updates for the embedded protocol.
f70c934 to
44efacf
Compare
401ed4d to
8be92f1
Compare
nex3
requested changes
Jul 21, 2023
Contributor
Author
|
I will add that I am comfortable volunteering to drive implementation should this proposal be accepted. |
8e78c65 to
e642055
Compare
nex3
requested changes
Jul 28, 2023
Contributor
nex3
left a comment
There was a problem hiding this comment.
Some minor change requests, but this is generally looking really good!
nex3
approved these changes
Jul 28, 2023
jgerigmeyer
added a commit
to oddbird/sass
that referenced
this pull request
Aug 7, 2023
* main: Bump tj-actions/changed-files from 37.4.0 to 37.5.1 (sass#3643) [First-Class Mixins] Create a proposal (sass#3626) [Calc Functions] Fix the definition of rem() (sass#3641) Bump tj-actions/changed-files from 37.1.2 to 37.4.0 (sass#3640) [Color 4] Clarify in Known Color Spaces that lightness is clamped (sass#3639) Add JS type definitions for calculations (sass#3622) Bump tj-actions/changed-files from 37.1.0 to 37.1.2 (sass#3635) [Calculation API] Fix some issues brought up during implementation (sass#3631) Bump tj-actions/changed-files from 37.0.5 to 37.1.0 (sass#3632) [Calc Functions] Match the spec's behavior better for percentages (sass#3630) Bump tj-actions/changed-files from 37.0.2 to 37.0.5 (sass#3627) Fix a reference to a dead link (sass#3625)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #3442 by addressing PR review and adding the function
meta.accepts-content.Inspired in part by sass/dart-sass#1958
Closes #3442
See #626