Merged
Conversation
This was referenced Jun 7, 2023
jerivas
commented
Jun 8, 2023
nex3
reviewed
Jun 9, 2023
Contributor
Author
|
@nex3 I think I addressed all your comments. This is ready for another round of review |
nex3
approved these changes
Jun 15, 2023
js-api-doc/value/calculation.d.ts
Outdated
Comment on lines
+96
to
+97
| * Creates a Sass CalculationOperation by setting the fields to the arguments | ||
| * of the corresponding names, and returns it. |
Contributor
There was a problem hiding this comment.
I think this still reads a bit spec-y. Maybe just "Creates a Sass CalculationOperation with the given [operator], [left], and [right] values."?
js-api-doc/value/calculation.d.ts
Outdated
Comment on lines
+125
to
+126
| * Creates a Sass CalculationInterpolation by setting the value field to the | ||
| * value argument and returns it. |
Contributor
There was a problem hiding this comment.
Similar comment to the constructor above.
js-api-doc/value/calculation.d.ts
Outdated
| } | ||
|
|
||
| /** | ||
| * A string injected into a {@link SassCalculation} using interpolation. |
Contributor
There was a problem hiding this comment.
Might be worth mentioning here that interpolations are different from unquoted strings in that they're always surrounded in parentheses when they appear in CalculationOperations.
nex3
added a commit
that referenced
this pull request
Jun 20, 2023
This reverts commit 3991504. This should only have been landed in parallel with the implementation and tests.
nex3
added a commit
that referenced
this pull request
Jun 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sass/dart-sass#1988
sass/sass-spec#1918