Revert "Add JS type defs for calculations (#3605)"#3619
Merged
Conversation
This reverts commit 3991504. This should only have been landed in parallel with the implementation and tests.
Contributor
Author
|
@jerivas Heads up, I merged your PR too early and had to revert because of course the types aren't implemented yet. Please re-open a PR to roll this forward and I'll be careful not to land it until the parallel PRs are ready as well 😅. |
jathak
approved these changes
Jun 20, 2023
Member
jathak
left a comment
There was a problem hiding this comment.
Not sure if you want to do a partial revert or just fully revert and partially roll forward, but the proposal changes here should be fine; it's just the actual spec changes that need to wait
Contributor
Author
|
Good call, un-reverted those. |
Contributor
@nex3 will do! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 3991504. This
should only have been landed in parallel with the implementation and
tests.