Replace relative imports by absolute ones in sage.{matrix,matroids,modules,stats}#36594
Merged
vbraun merged 3 commits intosagemath:developfrom Nov 5, 2023
Merged
Conversation
|
Documentation preview for this PR (built with commit 4370ea2; changes) is ready! 🎉 |
Contributor
Author
|
The pyright error is unrelated. Ready for review |
dcoudert
reviewed
Oct 31, 2023
Collaborator
dcoudert
left a comment
There was a problem hiding this comment.
otherwise LGTM and passes tests on Fedora 35.
| from copy import copy | ||
|
|
||
| import sage.modules.free_module | ||
| from . import berlekamp_massey |
Collaborator
There was a problem hiding this comment.
here we used from . import berlekamp_massey to import a module and it is replaced by from sage.matrix import berlekamp_massey. But in other places, for instance in src/sage/matroids/unpickling.pyx, we use import sage.matroids.matroid (not modified). I'm not sure of the difference between both forms. Which one is the most suited ?
Contributor
Author
There was a problem hiding this comment.
After from sage.matrix import berlekamp_massey, the module can be referred to as berlekamp_massey. This style tends to appear in older portions of the Sage source code. Personally I don't like it very much, but I have not made an effort to change it.
Contributor
Author
|
Thank you! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 1, 2023
sagemathgh-36594: Replace relative imports by absolute ones in `sage.{matrix,matroids,modules,stats}` <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> - Cherry-picked from sagemath#35095 - This is for sagemath#36228 <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36594 Reported by: Matthias Köppe Reviewer(s): David Coudert, Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 2, 2023
sagemathgh-36594: Replace relative imports by absolute ones in `sage.{matrix,matroids,modules,stats}` <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> - Cherry-picked from sagemath#35095 - This is for sagemath#36228 <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36594 Reported by: Matthias Köppe Reviewer(s): David Coudert, Matthias Köppe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Checklist
⌛ Dependencies