Skip to content

sage.matrix, sage.modules: Update # needs#36569

Merged
vbraun merged 19 commits intosagemath:developfrom
mkoeppe:needs_for_sage_matrix_sage_modules
Nov 5, 2023
Merged

sage.matrix, sage.modules: Update # needs#36569
vbraun merged 19 commits intosagemath:developfrom
mkoeppe:needs_for_sage_matrix_sage_modules

Conversation

@mkoeppe
Copy link
Copy Markdown
Contributor

@mkoeppe mkoeppe commented Oct 29, 2023

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

Matthias Koeppe added 19 commits October 30, 2023 18:07
@mkoeppe
sage.matrix: Fix # needs (sage -fixdoctests, manual)
8b0824e
@mkoeppe
sage -fixdoctests --distribution all --fixed-point --only-tags --prob…
1d01569 
…e all --verbose src/sage/matrix; followed by manual fixes
@mkoeppe
src/sage/matrix/matrix2.pyx (determinant): Fall back when PARI is not…
95d63df 
… available
@mkoeppe
Add # needs
8177e8a
@mkoeppe
Add # needs
a8a4b8e
@mkoeppe
sage.matrix: Add # needs
bdd0506
@mkoeppe
sage.{matrix,modules}: Update # needs
d366696
@mkoeppe
sage.matrix: Add # needs
433eb41
@mkoeppe
sage.modules: Update # needs
171adf5
@mkoeppe
sage.{matrix,modules}: Update # needs
4537cb4
@mkoeppe
sage.matrix: Add # needs
23ac349
@mkoeppe
sage.matrix: Add # needs
38119de
@mkoeppe
sage.modules: Update # needs
3cbfb0f
@mkoeppe
sage.matrix: Update # needs
403ece7
@mkoeppe
Update # needs
fabdf86
@mkoeppe
sage.matrix: Update # needs
119673d
@mkoeppe
sage.modules: Update # needs
e23670d
@mkoeppe
src/sage/matrix/matrix_space.py: Fix change to doctest
8402a7b
@mkoeppe
src/sage/matrix/matrix2.pyx: Fix doctest dataflow warning
c3b6f2f
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 31, 2023

Documentation preview for this PR (built with commit c3b6f2f; changes) is ready! 🎉

dcoudert
dcoudert approved these changes Oct 31, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know that # needs sage.libs.linbox can be used instead of sage.libs.flint. Not obvious.

Compile and passes tests on Fedora 35. LGTM.

@mkoeppe
Copy link
Copy Markdown
Contributor Author

mkoeppe commented Oct 31, 2023

I didn't know that # needs sage.libs.linbox can be used instead of sage.libs.flint. Not obvious.

Matrix_integer_dense is a very problematic module, which will need major work for modularization.
It imports lots of different libraries. Before the major work this year in #35095 to make working sagemath-flint and sagemath-linbox distributions, this # needs sage.libs.flint effectively meant "don't ever run in a modularized test". Now it's more specific.

Thanks for the review!

vbraun pushed a commit to vbraun/sage that referenced this pull request Nov 1, 2023
705c09d 
sagemathgh-36569: `sage.matrix`, `sage.modules`: Update `# needs`
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
- Cherry picked from sagemath#35095
- Part of sagemath#29705
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36569
Reported by: Matthias Köppe
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Nov 2, 2023
6cc3fc9 
sagemathgh-36569: `sage.matrix`, `sage.modules`: Update `# needs`
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
- Cherry picked from sagemath#35095
- Part of sagemath#29705
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36569
Reported by: Matthias Köppe
Reviewer(s): David Coudert
@vbraun vbraun merged commit bb7d146 into sagemath:develop Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcoudert dcoudert dcoudert approved these changes

Assignees

@mkoeppe mkoeppe

Labels

c: linear algebra t: refactoring

Projects

None yet

Milestone

sage-10.2

Development

Successfully merging this pull request may close these issues.

3 participants

@mkoeppe @dcoudert @vbraun