Change `ipympl`/`pkgconfig`/`widgetsnbextension` to wheel packages, drop build deps by mkoeppe · Pull Request #36267 · sagemath/sage

mkoeppe · 2023-09-14T18:35:00Z

Cherry-picked from Notebook 7, ipykernel 6.27, ipython 8.17 #36129

📝 Checklist

The title is concise, informative, and self-explanatory.
The description explains in detail what this PR is about.
I have linked a relevant issue or discussion.
I have created tests covering the changes.
I have updated the documentation accordingly.

⌛ Dependencies

Depends on Disable more packages with various --disable-foo combinations #36239 (merged here)

orlitzky · 2023-09-14T21:24:30Z

To save me from looking through the 362 changed files in the notebook-7.x PR... why are we making ipympl standard? Did it become a non-optional dependency of something standard during the notebook upgrade?

Aside from that I'm very happy to see the build dependencies disappear.

mkoeppe · 2023-09-14T21:26:33Z

It was requested in #36129 (comment) for added convenience.

orlitzky · 2023-09-14T21:35:02Z

It was requested in #36129 (comment) for added convenience.

Ok, makes sense I guess. I think it should be added to the --disable-notebook list in configure.ac now though.

mkoeppe · 2023-09-14T21:37:40Z

OK, I'll merge #36219 for that.

orlitzky · 2023-09-16T01:31:15Z

@egourgoulhon can you propose the new standard package on sage-devel so that no one can accuse us of funny business? (Despite being "standard," it's still pseudo-optional via --disable-notebook.)

orlitzky · 2023-09-16T01:33:14Z

Aside from that this LGTM and I can clean up any system package issues afterwards.

The pytz package is a dependency of three others: babel, rpy2, and tzlocal. And tzlocal is itself a dependency of rpy2. Babel is already disabled with --disable-doc, and rpy2 and tzlocal are disabled with --disable-r. It therefore makes sense to disable pytz when both --disable-doc and --disable-r are given.

The pycparser package is a dependency of two others, cffi and rpy2, which can be disabled with --disable-notebook and --disable-r respectively. As a result we can disable pycparser when both flags are present.

The pytz_deprecation_shim package is a dependency only of tzlocal, which is already disabled with --disable-r.

Passing --disable-notebook to ./configure already disables the argon2_cffi package, so it should be safe to disable its bindings as well.

The soupsieve package is a dependency of beautifulsoup4, which is already disabled with --disable-notebook. It should therefore be safe to disable soupsieve under the same circumstances.

The sphinx_basic_ng package is solely a dependency of furo, which is already disabled with --disable-doc. We should therefore disable sphinx_basic_ng with --disable-doc as well.

The fastjsonschema package is solely a dependency of nbformat, which is already disabled with --disable-notebook. We should therefore disable fastjsonschema with --disable-notebook as well.

mkoeppe · 2023-09-16T18:37:29Z

I've taken out the change of ipympl to standard; we can do that in #36129

orlitzky · 2023-09-16T23:19:04Z

OK then

github-actions

orlitzky approved this PR

mkoeppe · 2023-09-16T23:32:38Z

Thanks!

orlitzky · 2023-09-17T03:04:37Z

I think the deprecation package can be removed now as well. Grep and its commit message suggest that it was needed only for jupyter_packaging.

egourgoulhon · 2023-09-17T15:15:00Z

@egourgoulhon can you propose the new standard package on sage-devel so that no one can accuse us of funny business? (Despite being "standard," it's still pseudo-optional via --disable-notebook.)

Done in https://groups.google.com/g/sage-devel/c/fRufANUCNdY

dimpase

lgtm

vbraun · 2023-09-21T22:02:45Z

merge conflict

github-actions · 2023-09-23T03:34:06Z

Documentation preview for this PR (built with commit e5ac3c8; changes) is ready! 🎉

sagemathgh-36267: Change `ipympl`/`pkgconfig`/`widgetsnbextension` to wheel packages, drop build deps     - Cherry-picked from sagemath#36129  ### 📝 Checklist     - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies  - Depends on sagemath#36239 (merged here)  URL: sagemath#36267 Reported by: Matthias Köppe Reviewer(s): Dima Pasechnik, github-actions[bot]

sagemathgh-36276: Yet more spkg_configure for standard python packages This is a continuation of sagemath#36256 - Fixes sagemath#36301 - Fixes https://groups.google.com/g/sage- release/c/1wOBmhvNJqc/m/Jk14VAbjBAAJ (hence marked critical) ### 📝 Checklist     - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies - sagemath#36296: to use an up to date Sphinx - sagemath#36267: updated ipympl, etc Also, a Jupyter/Python issue was uncovered there, which might need work. URL: sagemath#36276 Reported by: Dima Pasechnik Reviewer(s): Matthias Köppe, Michael Orlitzky

sagemathgh-36802: Python toolchain as wheel packages   We switch several pure Python packages that are part of `PYTHON_TOOLCHAIN` from normal to wheel packages. The only time that we carried a patch for any of these packages was in 2014–2016, a patch for pyparsing. This reduces the complexity of our SPKGs, in line with previous PRs sagemath#36267, sagemath#36429, sagemath#36129, sagemath#36794.    ### 📝 Checklist     - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies   URL: sagemath#36802 Reported by: Matthias Köppe Reviewer(s): Dima Pasechnik

orlitzky mentioned this pull request Sep 15, 2023

Support more system-site packages #36256

Merged

orlitzky and others added 16 commits September 16, 2023 14:17

configure.ac: no cffi/pycparser with --disable-notebook and --disable-r

ca3d95b

The pycparser package is a dependency of two others, cffi and rpy2, which can be disabled with --disable-notebook and --disable-r respectively. As a result we can disable pycparser when both flags are present.

configure.ac: disable pytz_deprecation_shim with --disable-r

2edd973

The pytz_deprecation_shim package is a dependency only of tzlocal, which is already disabled with --disable-r.

configure.ac: disable argon2_cffi_bindings with --disable-notebook

c3521b9

Passing --disable-notebook to ./configure already disables the argon2_cffi package, so it should be safe to disable its bindings as well.

configure.ac: disable soupsieve with --disable-notebook

5b23bf6

The soupsieve package is a dependency of beautifulsoup4, which is already disabled with --disable-notebook. It should therefore be safe to disable soupsieve under the same circumstances.

configure.ac: disable sphinx_basic_ng with --disable-doc

fb5c951

The sphinx_basic_ng package is solely a dependency of furo, which is already disabled with --disable-doc. We should therefore disable sphinx_basic_ng with --disable-doc as well.

configure.ac: disable fastjsonschema with --disable-notebook

c59c407

The fastjsonschema package is solely a dependency of nbformat, which is already disabled with --disable-notebook. We should therefore disable fastjsonschema with --disable-notebook as well.

build/pkgs/ipympl: Switch to wheel package

3ad8227

build/pkgs/pkgconfig: Update to 1.5.5, change to wheel package

a1b6e72

build/pkgs/widgetsnbextension: Update to 4.0.8

01ff39e

build/pkgs/widgetsnbextension: Change to wheel package

7fda18c

build/pkgs/poetry_core: Remove

4ece267

build/pkgs/jupyter_packaging: Remove

1571d28

build/pkgs/tomlkit: Remove

68dc2d8

build/pkgs/pkgconfig/SPKG.rst: Restore hand-edited version

94b3aec

configure --disable-notebook: Disable ipympl

77aa9f1

orlitzky added s: positive review and removed s: needs review labels Sep 16, 2023

github-actions bot approved these changes Sep 16, 2023

View reviewed changes

dimpase approved these changes Sep 18, 2023

View reviewed changes

vbraun added the s: needs work label Sep 21, 2023

Merge branch 'more-disable-combinations' into prose_only

e5ac3c8

vbraun merged commit 4f8a8af into sagemath:develop Sep 27, 2023

github-actions bot removed the s: positive review label Sep 27, 2023

Uh oh!

Conversation

mkoeppe commented Sep 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Checklist

⌛ Dependencies

Uh oh!

orlitzky commented Sep 14, 2023

Uh oh!

mkoeppe commented Sep 14, 2023

Uh oh!

orlitzky commented Sep 14, 2023

Uh oh!

mkoeppe commented Sep 14, 2023

Uh oh!

orlitzky commented Sep 16, 2023

Uh oh!

orlitzky commented Sep 16, 2023

Uh oh!

mkoeppe commented Sep 16, 2023

Uh oh!

orlitzky commented Sep 16, 2023

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

mkoeppe commented Sep 16, 2023

Uh oh!

orlitzky commented Sep 17, 2023

Uh oh!

egourgoulhon commented Sep 17, 2023

Uh oh!

dimpase left a comment

Choose a reason for hiding this comment

Uh oh!

vbraun commented Sep 21, 2023

Uh oh!

github-actions bot commented Sep 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mkoeppe commented Sep 14, 2023 •

edited

Loading