configure.ac: disable webencodings,tinycss2 with --disable-notebook#36219
Merged
vbraun merged 1 commit intosagemath:developfrom Sep 16, 2023
Merged
configure.ac: disable webencodings,tinycss2 with --disable-notebook#36219vbraun merged 1 commit intosagemath:developfrom
vbraun merged 1 commit intosagemath:developfrom
Conversation
The --disable-notebook flag disables the bleach and nbconvert packages, and the webencodings and tinycss2 packages are (solely) dependencies of those. We can therefore disable webencodings and tinycss2 whenever --disable-notebook is given.
Contributor
Author
|
Note: tinycss2 is not listed as a dependency of anything at the moment, but nbconvert still requires it. This is already being fixed in #36186. |
|
Documentation preview for this PR (built with commit 76278ef; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 11, 2023
…disable-notebook The `--disable-notebook` flag disables the bleach and nbconvert packages, and the webencodings and tinycss2 packages are (solely) dependencies of those. We can therefore disable webencodings and tinycss2 whenever `--disable-notebook` is given. URL: sagemath#36219 Reported by: Michael Orlitzky Reviewer(s): Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 14, 2023
sagemathgh-36219: configure.ac: disable webencodings,tinycss2 with --disable-notebook The `--disable-notebook` flag disables the bleach and nbconvert packages, and the webencodings and tinycss2 packages are (solely) dependencies of those. We can therefore disable webencodings and tinycss2 whenever `--disable-notebook` is given. URL: sagemath#36219 Reported by: Michael Orlitzky Reviewer(s): Matthias Köppe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
--disable-notebookflag disables the bleach and nbconvert packages, and the webencodings and tinycss2 packages are (solely) dependencies of those. We can therefore disable webencodings and tinycss2 whenever--disable-notebookis given.